nsContinueDespiteCertError's default case should set rv

RESOLVED FIXED

Status

()

Core
Security: PSM
--
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity})

Trunk
PowerPC
Mac OS X
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 obsolete attachment)

(Assignee)

Description

12 years ago
currently both code paths result in PR_FALSE being returned, but purify and valgrind would complain about the jump
(Assignee)

Comment 1

12 years ago
Created attachment 218650 [details] [diff] [review]
set rv
Attachment #218650 - Flags: superreview?(bzbarsky)
Attachment #218650 - Flags: review?(kengert)
Attachment #218650 - Flags: superreview?(bzbarsky) → superreview+

Comment 2

12 years ago
Comment on attachment 218650 [details] [diff] [review]
set rv

r=kengert

patch can't hurt and adds clarity
Attachment #218650 - Flags: review?(kengert) → review+
(Assignee)

Comment 3

12 years ago
Comment on attachment 218650 [details] [diff] [review]
set rv

mozilla/security/manager/ssl/src/nsNSSIOLayer.cpp 	1.108
Attachment #218650 - Attachment is obsolete: true
(Assignee)

Updated

12 years ago
Assignee: kengert → timeless
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.