Closed Bug 334195 Opened 14 years ago Closed 12 years ago

XPCWrappedNative::HandlePossibleNameCaseError dereferences an unitialized value if !set

Categories

(Core :: XPConnect, defect, critical)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, crash)

Attachments

(1 file)

based on a lack of crash reports for this, it must be pretty unlikely...
Assignee: dbradley → timeless
Status: NEW → ASSIGNED
Attachment #218653 - Flags: superreview?(jst)
Attachment #218653 - Flags: review?(dbradley)
Comment on attachment 218653 [details] [diff] [review]
try using the other interface critter

sr=jst
Attachment #218653 - Flags: superreview?(jst) → superreview+
QA Contact: pschwartau → xpconnect
Flags: blocking1.9?
Given this is unlikely moving off blocking list - but we'd certainly take the patch...
Flags: blocking1.9?
Comment on attachment 218653 [details] [diff] [review]
try using the other interface critter

r=dbradley

Getting back on track. I applied the patch and it's still applies and is correct.

Minor nit ? and : should be on the previous line not starting the next line, to be inline with prevailing style. Statement lines appear tobe mostly indented twice (8 spaces) in other occurences in this file.
Attachment #218653 - Flags: review?(dbradley) → review+
Attachment #218653 - Flags: approval1.9?
Attachment #218653 - Flags: approval1.9? → approval1.9+
Whiteboard: [needs landing]
Comment on attachment 218653 [details] [diff] [review]
try using the other interface critter

mozilla/js/src/xpconnect/src/xpcwrappednative.cpp 	1.183
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.