Closed
Bug 334195
Opened 20 years ago
Closed 18 years ago
XPCWrappedNative::HandlePossibleNameCaseError dereferences an unitialized value if !set
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, crash)
Attachments
(1 file)
|
2.31 KB,
patch
|
dbradley
:
review+
jst
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
based on a lack of crash reports for this, it must be pretty unlikely...
Assignee: dbradley → timeless
Status: NEW → ASSIGNED
Attachment #218653 -
Flags: superreview?(jst)
Attachment #218653 -
Flags: review?(dbradley)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 218653 [details] [diff] [review]
try using the other interface critter
sr=jst
Attachment #218653 -
Flags: superreview?(jst) → superreview+
|
||
Updated•19 years ago
|
QA Contact: pschwartau → xpconnect
|
||
Updated•18 years ago
|
Flags: blocking1.9?
|
||
Comment 3•18 years ago
|
||
Given this is unlikely moving off blocking list - but we'd certainly take the patch...
Flags: blocking1.9?
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 218653 [details] [diff] [review]
try using the other interface critter
r=dbradley
Getting back on track. I applied the patch and it's still applies and is correct.
Minor nit ? and : should be on the previous line not starting the next line, to be inline with prevailing style. Statement lines appear tobe mostly indented twice (8 spaces) in other occurences in this file.
Attachment #218653 -
Flags: review?(dbradley) → review+
Attachment #218653 -
Flags: approval1.9?
|
|
||
Updated•18 years ago
|
Attachment #218653 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•18 years ago
|
Whiteboard: [needs landing]
Comment on attachment 218653 [details] [diff] [review]
try using the other interface critter
mozilla/js/src/xpconnect/src/xpcwrappednative.cpp 1.183
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
|
||
Updated•8 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•