Closed Bug 334204 Opened 14 years ago Closed 14 years ago

XPCConvert::JSValToXPCException is too cautious

Categories

(Core :: XPConnect, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 obsolete file)

js numbers are either ints or double tagged pointers. the double tagged pointers are supposed to not be null tagged as a double. but the code here is too cautious which upsets coverity.
Attached patch throw some caution to the wind (obsolete) — Splinter Review
Assignee: dbradley → timeless
Status: NEW → ASSIGNED
Attachment #218655 - Flags: superreview?(jst)
Attachment #218655 - Flags: review?(jst)
Comment on attachment 218655 [details] [diff] [review]
throw some caution to the wind

sr=jst, but requesting r= from mrbkap just for extra sanity checking here.
Attachment #218655 - Flags: superreview?(jst)
Attachment #218655 - Flags: superreview+
Attachment #218655 - Flags: review?(mrbkap)
Attachment #218655 - Flags: review?(jst)
Comment on attachment 218655 [details] [diff] [review]
throw some caution to the wind

I don't think there's any need for the assertion.
Attachment #218655 - Flags: review?(mrbkap) → review+
Comment on attachment 218655 [details] [diff] [review]
throw some caution to the wind

mozilla/js/src/xpconnect/src/xpcconvert.cpp 	1.100
Attachment #218655 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.