334213 - "Copy link location" should add UniformResourceLocator (URL) flavor to clipboard

Status: NEW

(Core :: Layout, defect)

Description

[David Gardiner]

When choosing "Copy Shortcut" from within IE, the following flavours are added to the DataObject in the Clipboard:

        FileContents
        FileGroupDescriptorW
        FileGroupDescriptor
        UniformResourceLocatorW
        System.String
        UnicodeText
        Text
        UniformResourceLocator

Where as Firefox currently only does these:
        System.String
        UnicodeText
        Text

It would be good to at least add support for the UniformResourceLocator and UniformResourceLocatorW flavours.

I think this would involve patching CopyLinkLocation in layout\base\nsDocumentViewer.cpp.

http://lxr.mozilla.org/seamonkey/source/layout/base/nsDocumentViewer.cpp#2488

-dave

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I wouldn't be so confident that that's what requires patching (did you trace through cmd_copyLink?), and I wouldn't be surprised if such a change required interface changes and changes to the clipboard stuff in widget/src/windows/ as well.

Comment 2

[David Gardiner]

I thought that was the likely place to patch after reviewing the call stack from a breakpoint I put in the clipboard code. You could be right though. If I have a go at doing a patch, then I'll no doubt get a better idea of what's really involved in fixing this.

-dave

Comment 3

[Wayne Mery (:wsmwk)]

related to/dupe bug 281873?