334305 - Importing bookmarks from Opera does not work

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Steps to reproduce:
1) Using Opera 8.54, add a couple of bookmarks
2) In Firefox, using either File->Import, or Organize Bookmarks->File->Import, try to import bookmarks from Opera

Actual results:
Success reported, but no bookmarks appear in the bookmarks menu or bookmarks toolbar

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Tested:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1

Comment 2

[Charli Li (winsxs)]

Have you looked in the sidebar of the bookmarks manager to find a "Imported from [app]" folder?
---
Please include your useragent in a comment.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Have you looked in the sidebar of the bookmarks manager to find a "Imported
> from [app]" folder?

Yes. When I said "does not work", I meant "does not work" :).

> Please include your useragent in a comment.

I included the UA string in comment 2. Please read bugs before commenting on them.

This bug only affects Places enabled builds.

Comment 4

[u279076]

Just to update this bug...

When I try to import settings from Opera 9.02 into Minefield 3.0a7pre (2007070604), only Opera's default bookmarks are carried over.  My browsing history, user saved bookmarks, and saved passwords are not imported.

I ran across this today during the test day.

Cheers.

Comment 5

[(not reading, please use [e-mail] instead)]

zoinks, I see the problem.  parentFolder is uninitialized, http://lxr.mozilla.org/seamonkey/source/browser/components/migration/src/nsOperaProfileMigrator.cpp#1055

simple fix in hand, will wait for dietrich to land his changes first.

Comment 6

[(not reading, please use [e-mail] instead)]

anthony:  can you log a spin off bug about the issues you are seeing in comment #4?

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: fixes import

Comment 8

[(not reading, please use [e-mail] instead)]

fixed.

Checking in src/nsOperaProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp,v
<--  nsOperaProfileMigrator.cpp
new revision: 1.71; previous revision: 1.70
done

Comment 9

[(not reading, please use [e-mail] instead)]

anthony wrote:

> When I try to import settings from Opera 9.02 into Minefield 3.0a7pre
> (2007070604), only Opera's default bookmarks are carried over.  My browsing
> history, user saved bookmarks, and saved passwords are not imported.

I just tried both first run migration and import and my bookmarks and history got migrated, as did cookies, but passwords did not.

I'm using Opera 9.23

looking at our code, we don't support opera password migration yet, and that is not an option in the manual import UI.

I've logged a new bug on that, see bug #394273

Comment 10

[u279076]

I verify that this bug is fixed.  One thing I noticed when doing my verification testing...

When importing Opera settings using the Migration Wizard, the bookmarks were placed in the root bookmarks folder (the same as they would if I had added them in firefox).

When importing Opera settings using the Import Wizard, the bookmarks were placed in an "From Opera" folder within Bookmarks.

Comment 11

[(not reading, please use [e-mail] instead)]

anthony, thanks for verifying.

what you observed in comment #10 (that first run migration is different than import) is by design.

We do the same thing from IE, and all browser should do that.

Comment 12

[Marcia Knous [:marcia]]

I will handle adding the Litmus test case for this one.

Comment 13

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=1647 was updated to cover importing Opera data. There is already an existing test case for migration.