Last Comment Bug 334328 - nsspkcs5_PKCS12PBE: Variable "A" tracked as NULL was dereferenced.
: nsspkcs5_PKCS12PBE: Variable "A" tracked as NULL was dereferenced.
Status: RESOLVED FIXED
CID 505
: coverity, crash
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11
: All All
: P2 critical (vote)
: 3.11.1
Assigned To: Alexei Volkov
:
:
Mentors:
http://bonsai.mozilla.org/cvsblame.cg...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-17 03:22 PDT by timeless
Modified: 2006-06-10 19:16 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
null check A ... (937 bytes, patch)
2006-04-17 21:24 PDT, timeless
nelson: review+
alvolkov.bgs: review+
Details | Diff | Splinter Review

Description timeless 2006-04-17 03:22:08 PDT
found by coverity
Comment 1 Nelson Bolyard (seldom reads bugmail) 2006-04-17 17:11:54 PDT
Clearly the code at "loser" should not crash if A is NULL.
Comment 2 timeless 2006-04-17 21:24:26 PDT
Created attachment 218766 [details] [diff] [review]
null check A ...
Comment 3 Alexei Volkov 2006-04-21 18:14:04 PDT
tip:
/cvsroot/mozilla/security/nss/lib/softoken/lowpbe.c,v  <--  lowpbe.c
new revision: 1.16; previous revision: 1.15

3.11 branch:
/cvsroot/mozilla/security/nss/lib/softoken/lowpbe.c,v  <--  lowpbe.c
new revision: 1.14.2.2; previous revision: 1.14.2.1
Comment 4 Nelson Bolyard (seldom reads bugmail) 2006-06-10 19:16:12 PDT
CID 505

Note You need to log in before you can comment on or make changes to this bug.