334356 - Remove nsIImportMimeEncode

Status: RESOLVED FIXED

(MailNews Core :: Import, task)

Description

[Håkan Waara]

nsIImportMimeEncode is currently unused.

See http://lxr.mozilla.org/mozilla/search?string=nsIImportMimeEncode

Is it still useful? If not, we could remove it to save code-size and reduce compile time...

Comment 1

[David :Bienvenu]

good one, looks like this isn't used, but is getting linked in. The functionality it purports to provide looks like it might be more generally useful (mime encoding attachments, for example), but I doubt any extensions were using it.

I wonder if Outlook import does handle attachments at all - if not, this code might need to be resurrected.

Comment 2

[Håkan Waara]

I suggest we comment it out for now in the makefiles, and open a new bug on this issue.

Comment 3

[Håkan Waara]

... or remove (for now).  And then whoever takes on the spin-off can just look at this patch for reference.

Comment 4

[Wayne Mery (:wsmwk)]

Still there https://searchfox.org/comm-central/search?q=nsIImportMimeEncode&path=

Comment 5

[Somu]

Hi I would really like to work on this as a start and motivation to contribute more to Thunderbird. Please assign this to me. I will complete and close this ASAP. Thankyou.

Comment 6

[Magnus Melin [:mkmelin]]

Hi Somo, please go ahead! Let me know if you have any questions.

Comment 7

[Magnus Melin [:mkmelin]]

So to get started, the code in question you can find using the search from comment 4: https://searchfox.org/comm-central/search?q=nsIImportMimeEncode&path=

Once you've removed the code, and made sure it still compiles, please attach a patch - see https://developer.thunderbird.net/contributing/fixing-a-bug

Comment 8

[Somu]

Attachment: This is the patch which solves this issue. It basically removes the usage of `nsImportMimeEncode` wherever it is used

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9069336 [details] [diff] [review]
This is the patch which solves this issue. It basically removes the usage of `nsImportMimeEncode` wherever it is used

Review of attachment 9069336 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7389c579b868
Remove unused nsIImportMimeEncode.idl and related code. r=mkmelin