Closed
Bug 334399
Opened 18 years ago
Closed 18 years ago
icons for sherlock plugins loaded from non-profile locations aren't loaded
Categories
(Firefox :: Search, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha2
People
(Reporter: Gavin, Assigned: Gavin)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.83 KB,
patch
|
mconnor
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Currently, only sherlock files in the profile get icons. Since sherlock plugins can be installed in extensions (or potentially in the application directory, though this is less likely), we need to make sure the icon loads correctly.
|
Assignee | |
Comment 1•18 years ago
|
||
Only convert if isWritable, but check for an icon regardless.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #218731 -
Flags: review?(mconnor)
Attachment #218731 -
Flags: approval-branch-1.8.1?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Priority: -- → P1
Whiteboard: [patch-r?]
|
||
Updated•18 years ago
|
Attachment #218731 -
Flags: review?(mconnor)
Attachment #218731 -
Flags: review+
Attachment #218731 -
Flags: approval-branch-1.8.1?(mconnor)
Attachment #218731 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 2•18 years ago
|
||
mozilla/browser/components/search/nsSearchService.js 1.1.2.11 mozilla/browser/components/search/nsSearchService.js 1.14
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [patch-r?]
You need to log in
before you can comment on or make changes to this bug.
Description
•