If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use $(SUNBIRD_VERSION) rather than `cat /moz.../version.txt` in Makefiles

VERIFIED FIXED

Status

Calendar
General
--
minor
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Matthew (lilmatt) Willis, Assigned: Matthew (lilmatt) Willis)

Tracking

Details

Attachments

(3 attachments)

(Assignee)

Description

12 years ago
We'd like to be able to set Sunbird's version once, similar to Ff,Tb and Sm, and use it in various Makefiles throughout the build process.

This would be useful for things such as building DOMi or Venkman, and passing it a version number for its install.rdf.

Migrating our stuff to one place also means we only have to change one `cat /moz.../version.txt` in the future if we move/rename where the version is pulled from.

Since this will touch various modules, I'm going to make multiple small patches so only the r/sr? folk will only have to review patches relevant to them, versus trying to grok a 200k file or something.
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

12 years ago
Created attachment 218750 [details] [diff] [review]
patch A, rev0 - gives us $(SUNBIRD_VERSION)
Attachment #218750 - Flags: second-review?
Attachment #218750 - Flags: first-review?
(Assignee)

Updated

12 years ago
Attachment #218750 - Flags: second-review?(benjamin)
Attachment #218750 - Flags: second-review?
Attachment #218750 - Flags: first-review?(dmose)
Attachment #218750 - Flags: first-review?
Attachment #218750 - Flags: approval-branch-1.8.1?(benjamin)

Comment 2

12 years ago
Comment on attachment 218750 [details] [diff] [review]
patch A, rev0 - gives us $(SUNBIRD_VERSION)

r=dmose
Attachment #218750 - Flags: first-review?(dmose) → first-review+

Updated

12 years ago
Attachment #218750 - Flags: second-review?(benjamin)
Attachment #218750 - Flags: second-review+
Attachment #218750 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #218750 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 3

12 years ago
Created attachment 218833 [details] [diff] [review]
patch B, rev0 - more $(SUNBIRD_VERSION)
Attachment #218833 - Flags: second-review?(benjamin)
Attachment #218833 - Flags: first-review?(dmose)
Attachment #218833 - Flags: approval-branch-1.8.1?(benjamin)
(Assignee)

Updated

12 years ago
Blocks: 267789

Comment 4

12 years ago
Comment on attachment 218833 [details] [diff] [review]
patch B, rev0 - more $(SUNBIRD_VERSION)

r=dmose
Attachment #218833 - Flags: first-review?(dmose) → first-review+

Updated

12 years ago
Attachment #218833 - Flags: second-review?(benjamin)
Attachment #218833 - Flags: second-review+
Attachment #218833 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #218833 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 5

12 years ago
Patches A and B checked in on branch and trunk.

Bug 267789, which relies on $(SUNBIRD_VERSION) being defined, is no longer blocked.
No longer blocks: 267789
(Assignee)

Comment 6

12 years ago
Created attachment 220347 [details] [diff] [review]
patch C, rev0 - default theme now uses $(SUNBIRD_VERSION)

This is in reference to bug 335753 comment 22.
https://bugzilla.mozilla.org/show_bug.cgi?id=335753#c22
Attachment #220347 - Flags: first-review?(mvl)
Comment on attachment 220347 [details] [diff] [review]
patch C, rev0 - default theme now uses $(SUNBIRD_VERSION)

r=mvl
Attachment #220347 - Flags: first-review?(mvl) → first-review+
Whiteboard: [needs landing]
(Assignee)

Comment 8

12 years ago
Patch C checked in on trunk and MOZILLA_1_8_BRANCH

Leaving bug open for further uses
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
(Assignee)

Comment 9

12 years ago
-> VERIFIED

Will reopen if we find more places we need this
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.