Closed
Bug 334417
Opened 18 years ago
Closed 18 years ago
Use $(SUNBIRD_VERSION) rather than `cat /moz.../version.txt` in Makefiles
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(3 files)
|
1.87 KB,
patch
|
dmosedale
:
first-review+
benjamin
:
second-review+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
|
827 bytes,
patch
|
dmosedale
:
first-review+
benjamin
:
second-review+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
|
3.47 KB,
patch
|
mvl
:
first-review+
|
Details | Diff | Splinter Review |
We'd like to be able to set Sunbird's version once, similar to Ff,Tb and Sm, and use it in various Makefiles throughout the build process. This would be useful for things such as building DOMi or Venkman, and passing it a version number for its install.rdf. Migrating our stuff to one place also means we only have to change one `cat /moz.../version.txt` in the future if we move/rename where the version is pulled from. Since this will touch various modules, I'm going to make multiple small patches so only the r/sr? folk will only have to review patches relevant to them, versus trying to grok a 200k file or something.
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #218750 -
Flags: second-review?
Attachment #218750 -
Flags: first-review?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #218750 -
Flags: second-review?(benjamin)
Attachment #218750 -
Flags: second-review?
Attachment #218750 -
Flags: first-review?(dmose)
Attachment #218750 -
Flags: first-review?
Attachment #218750 -
Flags: approval-branch-1.8.1?(benjamin)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 218750 [details] [diff] [review] patch A, rev0 - gives us $(SUNBIRD_VERSION) r=dmose
Attachment #218750 -
Flags: first-review?(dmose) → first-review+
|
||
Updated•18 years ago
|
Attachment #218750 -
Flags: second-review?(benjamin)
Attachment #218750 -
Flags: second-review+
Attachment #218750 -
Flags: approval-branch-1.8.1?(benjamin)
Attachment #218750 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #218833 -
Flags: second-review?(benjamin)
Attachment #218833 -
Flags: first-review?(dmose)
Attachment #218833 -
Flags: approval-branch-1.8.1?(benjamin)
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 218833 [details] [diff] [review] patch B, rev0 - more $(SUNBIRD_VERSION) r=dmose
Attachment #218833 -
Flags: first-review?(dmose) → first-review+
|
|
||
Updated•18 years ago
|
Attachment #218833 -
Flags: second-review?(benjamin)
Attachment #218833 -
Flags: second-review+
Attachment #218833 -
Flags: approval-branch-1.8.1?(benjamin)
Attachment #218833 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 5•18 years ago
|
||
Patches A and B checked in on branch and trunk. Bug 267789, which relies on $(SUNBIRD_VERSION) being defined, is no longer blocked.
No longer blocks: 267789
|
|
Assignee | |
Comment 6•18 years ago
|
||
This is in reference to bug 335753 comment 22. https://bugzilla.mozilla.org/show_bug.cgi?id=335753#c22
Attachment #220347 -
Flags: first-review?(mvl)
|
||
Comment 7•18 years ago
|
||
Comment on attachment 220347 [details] [diff] [review] patch C, rev0 - default theme now uses $(SUNBIRD_VERSION) r=mvl
Attachment #220347 -
Flags: first-review?(mvl) → first-review+
|
|
||
Updated•18 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 8•18 years ago
|
||
Patch C checked in on trunk and MOZILLA_1_8_BRANCH Leaving bug open for further uses
|
|
Assignee | |
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 9•18 years ago
|
||
-> VERIFIED Will reopen if we find more places we need this
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•