334462 - Text on hovered combobox is invisible on high contrast inverse theme.

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Tim Miao]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050607 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1

This bug makes this combobox invisible, please fix it.

Reproducible: Always

Steps to Reproduce:
1. Change gnome theme settings, select Launch bar->Desktop->Preferences->Theme,
select High ContrastInverse theme, then click Theme Details button. Select
Controls tab and set HighContrastLargePrintInverse, select Icon tab and set
HighContrastInverse. Then close these two setting dialog.
2. Open preferences dialog and go to Advanced tab.
3. In General tab, click Edit Languages button.
4. Move mouse cursor above Select a languate to add... combobox.

Actual Results:  
The combobox turned white, the text label on it is not visible.

Expected Results:  
The label should be visible in this kind of theme settings.

This bug can be reproduced on vermillion_09/svn_36 with Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1.

Comment 1

[Tim Miao]

Attachment: Screenshot

Comment 2

[Brett Wilson]

*** Bug 335316 has been marked as a duplicate of this bug. ***

Comment 3

[Mark Pilgrim (inactive)]

WFM, Bon Echo 2006-05-15 build and Minefield 2006-05-17 build.

Comment 4

[Tim Miao]

This bug is still reproducible in following tabs:
  Main Tab: Show my homepage combobox
  Content Tab: Font combobox, Font Size combobox and in the Advanced font setting
  Privacy Tab: They expire combobox
  Security Tab: Google combobox
  Advanced Tab: General Tab->Choose Language combobox

Comment 5

[Ginn Chen]

confirmed

Comment 7

[Teune van Steeg]

Attachment: patch

I noticed that the same problem is also visible for tree/list headers, so I included that as well in this patch.

This patch copies the colors used for toolbar buttons: the color ButtonText for active comboboxes and tree/list headers, and the color -moz-button-hovertext for hover over the same widgets.

Note that this doesn't fix this issue for buttons and comboboxes in HTML. I'll file another bug for that (since that requires CSS that effects all platforms).

Comment 8

[Teune van Steeg]

Adjusting the summary so it better describes the issue.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 299079 [details] [diff] [review]
patch

CVS reports "malformed patch at line 136", but manually applying the patch works fine and fixes the cases I tested. r=myk

Comment 10

[Teune van Steeg]

Attachment: patch against latest revisions

This is the same patch, but against the latest revisions of the files involved. I hope that will prevent the CVS error.

Comment 11

[Teune van Steeg]

Attachment: patch against latest revisions

Sorry, I just noticed that the previous patch was the wrong one. This is the correct patch

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299238 [details] [diff] [review]
patch against latest revisions

a=beltzner for 1.9 assuming this is the right patch :)

Comment 13

[Teune van Steeg]

(In reply to comment #12)
> (From update of attachment 299238 [details] [diff] [review])
> a=beltzner for 1.9 assuming this is the right patch :)
> 
Just to take away any uncertainties: yes it is.

Comment 14

[Myk Melez [:myk] [@mykmelez]]

Thanks for the fix!

Checking in toolkit/themes/gnomestripe/global/menulist.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/menulist.css,v  <--  menulist.css
new revision: 1.8; previous revision: 1.7
done
Checking in toolkit/themes/gnomestripe/global/tree.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/tree.css,v  <--  tree.css
new revision: 1.11; previous revision: 1.10
done
Checking in toolkit/themes/gnomestripe/global/listbox.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/listbox.css,v  <--  listbox.css
new revision: 1.6; previous revision: 1.5
done