334524 - Safe browsing extension triggers shutdown asserts

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[Boris Zbarsky [:bzbarsky]]

With safe browsing extension enabled, on shutdown I get:

###!!! ASSERTION: Event listener manager hash not empty at shutdown!: 'sEventListenerManagersHash.entryCount == 0', file ../../../../mozilla/content/base/src/nsContentUtils.cpp, line 642
###!!! ASSERTION: Using observer service after XPCOM shutdown!: 'Error', file ../../../mozilla/xpcom/ds/nsObserverService.cpp, line 140
###!!! ASSERTION: not an nsIRDFRemoteDataSource: 'remote != nsnull', file ../../../../mozilla/rdf/datasource/src/nsLocalStore.cpp, line 345

The second assert is from ~nsDownloadManager calling removeObserver after it's released in nsComponentManagerImpl::FreeServices.

The third assert is from LocalStoreImpl::Flush called by ~nsXULDocument (which is being released via GC after mozJSComponentLoader::UnloadModules.

None of these asserts are hit without safe-browsing.  At a guess, safe-browsing is getting the shutdown notification after layout, and it's holding on to layout things (like that nsXULDocument).

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 332591 has been marked as a duplicate of this bug. ***

Comment 2

[Tony Chang (Google)]

I removed the extension from CVS (bug 337336) so this should no longer be an
issus.