Closed
Bug 334547
Opened 19 years ago
Closed 19 years ago
Get rid of weird scrollframe code in nsCSSFrameConstructor::ConstructDocElementFrame
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
Attachments
(1 file)
|
3.13 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
There's a significant amount of code in ConstructDocElementFrame that executes only if isScrollable is true. However, isScrollable is never true. If IsScrollableOverflow() is true and the document isn't paginated, PropagateScrollToViewport() will return the root content element, so propagatedScrollToViewport will be true, so !propagatedScrollToViewport will be false. Therefore, isScrollable is false in all cases.
Because isScrollable is always false, we should get rid of it.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #218931 -
Flags: superreview+
Attachment #218931 -
Flags: review?(roc)
Attachment #218931 -
Flags: review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
Note: accidentally checked bug 334699 (dealing with widget code) referencing this bug.
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
||
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•