Closed Bug 334578 Opened 17 years ago Closed 7 years ago

Icons in 'Find' tool bar are not compliant with theme settings.

Categories

(Toolkit :: Themes, defect, P3)

Product:
Toolkit
Component:
Themes
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: tim.miao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: p=3)

Attachments

(2 files)

Screenshot - Windows 8.1, black on white
13.01 KB, image/png
Details
patch
1.59 KB, patch
jaws
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050607 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1

Icons are not compliant with theme setting.

Reproducible: Always

Steps to Reproduce:
1.Change gnome theme settings, select Launch bar->Desktop->Preferences->Theme,
select High ContrastInverse theme, then click Theme Details button. Select
Controls tab and set HighContrastLargePrintInverse, select Icon tab and set
HighContrastInverse. Then close these two setting dialog.
2. Launch Firefox and load a webpage, say http://www.sun.com/ .
3. Press Ctrl+F to open the search bar.

Actual Results:  
All the icons in search bar are not compliant with theme settings.

Expected Results:  
These icons should be compliant with theme settings.

This bug can be found on vermillion_09/snv_36 with Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1.
Keywords: access
OS: Other → Solaris
Hardware: Other → Sun
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5
Tim, how does this affect a11y? If it does mark it as blocking bug 343205, otherwise clear the access keyword.
OS: Solaris → All
Hardware: Sun → All
Blocks: themea11y
Keywords: sec508
Severity: enhancement → normal
Priority: P5 → P3
Target Milestone: --- → Firefox 2 beta2
Flags: blocking-firefox2?
Given the unknowns around how this would be properly implemented, and the very late timeframe, not going to block on this, but we need to figure out the path forward.
Flags: blocking-firefox2? → blocking-firefox2-
Target Milestone: Firefox 2 beta2 → Firefox 3
Still an issue in Australis.
Blocks: fx-high-contrast
Target Milestone: Firefox 3 → ---
Flags: firefox-backlog+
Whiteboard: p=3
Component: Disability Access → Themes
Depends on: 1271680
Product: Firefox → Toolkit
Attached patch patch — — Splinter Review 
Bug 1271680 got us half-way there by fixing the icons, but the gradient in the background is still too strong.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8771051 - Flags: review?(jaws)
Attachment #8771051 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/755425c1a68e
Make the gradient in the background of the prev/next buttons less strong to better integrate with dark themes. r=jaws
https://hg.mozilla.org/mozilla-central/rev/755425c1a68e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.