Closed Bug 334724 Opened 14 years ago Closed 14 years ago

browsing monthview is broken

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mvl, Unassigned)

References

Details

Attachments

(1 file)

After the checking for bug 334704, browsing the monthview breaks once you have looked at may. May shows an extra row, without anything in it.
We either need to fix this, or work around it by disabling the re-use of the grid.
Attached patch patchSplinter Review
This cose used to be never called. Now that it actually gets called, it turns out that the duration is negative, not positive.
Attachment #219185 - Flags: first-review?(dmose)
Since it sounds like there's overlap between this bug 334996, I'm gonna hold off reviewing this one until we've got the appropriate patch attached there as well.
Attachment #219185 - Flags: first-review?(dmose)
(In reply to comment #2)
> Since it sounds like there's overlap between this bug 334996, I'm gonna hold
> off reviewing this one until we've got the appropriate patch attached there as
> well.

On a closer look my patch on Bug 334996 reverts to the behaviour as before the check in for Bug 334704 (We always recreate the grid instead of reusing).

I think Michiels patch is correct here and should be reviewed and checked in.
Comment on attachment 219185 [details] [diff] [review]
patch

I still think this patch is  correct. re-requesting review.
Attachment #219185 - Flags: first-review?(dmose)
Comment on attachment 219185 [details] [diff] [review]
patch

r=dmose
Attachment #219185 - Flags: first-review?(dmose) → first-review+
patch checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.