All users were logged out of Bugzilla on October 13th, 2018

Misleading comment (wrong code?) in nsWindowsShellService.cpp

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
13 years ago
11 years ago

People

(Reporter: mcsmurf, Unassigned)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

13 years ago
The code comment of this line
193 #define DDE_NAME "Firefox" // This must be kept in sync with ID_DDE_APPLICATION_NAME as defined in splash.rc
in nsWindowsShellService.cpp is misplaced there. ID_DDE_APPLICATION_NAME no longer exists in the splash.rc version of Firefox. It was removed as part of Bug 258217.
Now should this comment say to keep this define in sync with the nsXREAppData from nsBrowserApp.cpp or should the nsWindowsShellService also get the app name from nsXREAppData (not sure how far this is possible/wanted)?
This was cleaned up as part of bug 370571. Resolving -> WFM.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.