Closed Bug 334753 Opened 19 years ago Closed 17 years ago

Misleading comment (wrong code?) in nsWindowsShellService.cpp

Categories

(Firefox :: Shell Integration, defect)

Product:
Firefox
Component:
Shell Integration
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: mcsmurf, Unassigned)

Details

The code comment of this line 193 #define DDE_NAME "Firefox" // This must be kept in sync with ID_DDE_APPLICATION_NAME as defined in splash.rc in nsWindowsShellService.cpp is misplaced there. ID_DDE_APPLICATION_NAME no longer exists in the splash.rc version of Firefox. It was removed as part of Bug 258217. Now should this comment say to keep this define in sync with the nsXREAppData from nsBrowserApp.cpp or should the nsWindowsShellService also get the app name from nsXREAppData (not sure how far this is possible/wanted)?
This was cleaned up as part of bug 370571. Resolving -> WFM.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.