Closed
Bug 334756
Opened 18 years ago
Closed 18 years ago
make UA string (user agent) for trunk releases not say Firefox
Categories
(Firefox Build System :: General, defect, P2)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2 alpha2
People
(Reporter: dbaron, Assigned: dbaron)
References
()
Details
(Whiteboard: [patch])
Attachments
(1 file)
2.55 KB,
patch
|
mconnor
:
review+
darin.moz
:
superreview+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
It's been suggested that releases not branded as Firefox shouldn't say Firefox in the UA string. See http://groups.google.com/group/mozilla.dev.planning/browse_frm/thread/099399cc15401d8e/8bd055de53133707#8bd055de53133707
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #219082 -
Flags: superreview?(darin)
Attachment #219082 -
Flags: review?(mconnor)
Assignee | ||
Updated•18 years ago
|
Whiteboard: [patch]
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox 2 alpha2
Comment 2•18 years ago
|
||
Comment on attachment 219082 [details] [diff] [review] use all the alphabetic characters of MOZ_APP_DISPLAYNAME instead Nice!
Attachment #219082 -
Flags: superreview?(darin) → superreview+
Comment 3•18 years ago
|
||
In terms of making things easier to understand for people using our products, I'm *all* for this.
Assignee | ||
Comment 4•18 years ago
|
||
I'm also for this in that it reduces the danger of Web authors sniffing for Firefox when they should be sniffing for Gecko, since it will lower the high percentage of Gecko UAs that are Firefox (especially among testers / early adopters).
Updated•18 years ago
|
Attachment #219082 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•18 years ago
|
||
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Attachment #219082 -
Flags: approval-branch-1.8.1?(mconnor)
Updated•18 years ago
|
Attachment #219082 -
Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Comment 7•18 years ago
|
||
Benefits of the change: * Fewer people yelling "Look, a Firefox 3 alpha!" on Digg every time a tinderbox uploads an hourly build. * Fewer sites broken in Camino, Seamonkey, etc. Drawbacks of the change: * Fewer people yelling "Look, a Firefox 3 alpha!" might mean fewer trunk testers. * Gecko trunk nightlies and alphas gets less testing because major sites being broken prevents testers from using those builds for daily browsing.
Comment 8•18 years ago
|
||
(In reply to comment #7) > Drawbacks of the change: You missed one: * All those sites that are reporting usage by browser will now report lower percentages for Firefox. Not sure this is a good thing from a markting perspective.
Comment 9•18 years ago
|
||
You missed a benefit: * Better support for Gecko on websites. So for example if we ship a mobile browser (say Minimo), it'll work "out of the box".
Comment 10•18 years ago
|
||
> * All those sites that are reporting usage by browser will now report lower
> percentages for Firefox.
Negligible. Nightly users number maybe ten thousand if we're generous, actual users in the 10's of millions. It's not going to move the needle any.
Comment 11•18 years ago
|
||
Bug 338306 is an example of a site (aircanada.com) sniffing for "Firefox", and, as a result, breaking on trunk builds since this was fixed. Would it be useful to mark such bugs as depending on this one (or vice versa)?
Comment 12•18 years ago
|
||
(In reply to comment #11) > Would it be useful to mark such bugs as depending on this one (or vice versa)? No, they should block bug 334967 :)
Updated•14 years ago
|
Summary: make UA string for trunk releases not say Firefox → make UA string (user agent) for trunk releases not say Firefox
Comment 13•14 years ago
|
||
For reference, bug 588874 changed the UA back to say Firefox instead of Minefield.
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•5 years ago
|
Keywords: fixed1.8.1
Target Milestone: Firefox 2 alpha2 → mozilla2 alpha2
You need to log in
before you can comment on or make changes to this bug.
Description
•