Closed Bug 334756 Opened 18 years ago Closed 18 years ago

make UA string (user agent) for trunk releases not say Firefox

Categories

(Firefox Build System :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2 alpha2

People

(Reporter: dbaron, Assigned: dbaron)

References

()

Details

(Whiteboard: [patch])

Attachments

(1 file)

Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox 2 alpha2
Comment on attachment 219082 [details] [diff] [review]
use all the alphabetic characters of MOZ_APP_DISPLAYNAME instead

Nice!
Attachment #219082 - Flags: superreview?(darin) → superreview+
In terms of making things easier to understand for people using our products, I'm *all* for this.
I'm also for this in that it reduces the danger of Web authors sniffing for Firefox when they should be sniffing for Gecko, since it will lower the high percentage of Gecko UAs that are Firefox (especially among testers / early adopters).
Attachment #219082 - Flags: review?(mconnor) → review+
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #219082 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #219082 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Checked in to MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1
Benefits of the change:
* Fewer people yelling "Look, a Firefox 3 alpha!" on Digg every time a tinderbox uploads an hourly build.
* Fewer sites broken in Camino, Seamonkey, etc.

Drawbacks of the change:
* Fewer people yelling "Look, a Firefox 3 alpha!" might mean fewer trunk testers.
* Gecko trunk nightlies and alphas gets less testing because major sites being broken prevents testers from using those builds for daily browsing.
(In reply to comment #7)
> Drawbacks of the change:

You missed one:

  * All those sites that are reporting usage by browser will now report lower percentages for Firefox.

Not sure this is a good thing from a markting perspective.
You missed a benefit:

  * Better support for Gecko on websites.

So for example if we ship a mobile browser (say Minimo), it'll work "out of the box".
>   * All those sites that are reporting usage by browser will now report lower
>     percentages for Firefox.

Negligible. Nightly users number maybe ten thousand if we're generous, actual users in the 10's of millions. It's not going to move the needle any.
Bug 338306 is an example of a site (aircanada.com) sniffing for "Firefox", and, as a result, breaking on trunk builds since this was fixed.

Would it be useful to mark such bugs as depending on this one (or vice versa)?
(In reply to comment #11)
> Would it be useful to mark such bugs as depending on this one (or vice versa)?

No, they should block bug 334967 :)
Depends on: 402648
Summary: make UA string for trunk releases not say Firefox → make UA string (user agent) for trunk releases not say Firefox
For reference, bug 588874 changed the UA back to say Firefox instead of Minefield.
Component: Build Config → General
Product: Firefox → Firefox Build System
Keywords: fixed1.8.1
Target Milestone: Firefox 2 alpha2 → mozilla2 alpha2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: