334760 - When printing an iframe using cocoa widgets: "Printer Error: An unknown error occurred while printing"

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Eli Friedman]

Pretty self-explanatory.  Potential fix: in nsPresShell::CreateRenderingContext, add loop to search for the widget that stops at the root view.

Comment 1

[Eli Friedman]

Hmm, I'm rather tempted to make nsIView::CreateWidget not create a widget when there isn't a parent widget; that would be the most correct thing to do.  I'm not really prepared to deal with the regressions from that at this point, however.  I'll file a bug on that, I think, and put the hack fix in here for the moment.

Comment 2

[Eli Friedman]

Attachment: Patch

Someone on the Mac needs to double-check that this works, but it should.  The idea is that we shouldn't make a widget if we're not going to initialize it.  I won't be able to work on Gecko for a long time after Saturday, though, so I don't really want to take responsibility for a somewhat risky change like this.

Comment 3

[Mark Mentovai]

Attachment: Crash log

Attachment 219237 [details] [diff] causes this crash when attempting to print a page with an iframe.

Comment 4

[Eli Friedman]

Comment on attachment 219237 [details] [diff] [review]
Patch

Cancelling review.

Well, that's weird; it's not crashing in my Windows non-Cairo build.  It ought to as far as I can tell.  Oh well.  I guess we're back to adding a check to nsPresShell::CreateRenderingContext.

Comment 5

[Eli Friedman]

Attachment: Patch

Sorry this took so long; I'm almost certain this will work, although someone should double-check.  Mark?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hello Mark? :-)

Comment 7

[Eli Friedman]

Note Bug 338904 comment 7.

Comment 8

[Mark Mentovai]

Comment on attachment 224355 [details] [diff] [review]
Patch

Hello!

I'll look at this first thing tomorrow morning.

Comment 9

[Mark Mentovai]

Comment on attachment 224355 [details] [diff] [review]
Patch

Looks good to me.  What's more, it even works!

Comment 10

[Eli Friedman]

Checked in.