334768 - bzip2 compression is broken

Status: RESOLVED FIXED

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Brian Ryner (not reading)]

CompressBZ2() is failing due to not running BZ_FINISH.  As it turns out, we can avoid using this whole stream API and just fopen the file ourselves, without introducing a CRT incompatibility.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

I cleaned up the GetDataFile() methods while I was at it (this change makes us no longer require a nsILocalFile for the compression output).

Comment 2

[Darin Fisher]

Comment on attachment 219094 [details] [diff] [review]
patch

Oh, I remember now why I didn't do this :-(

You should use GetPath + _wfopen on Windows to avoid Unicode path problems.  But that is not supported on Win9x, so you'd need to failover to calling GetNativePath + fopen on Win9x.

xpcom/io/nsWinAPIs.h defines mFOpen which implements the failover for you.  You can't link to that though.

Comment 3

[Darin Fisher]

Another choice is to use OpenNSPRFileDesc + PR_FileDesc2NativeHandle + _open_osfhandle + _fdopen :-)

Comment 4

[Brian Ryner (not reading)]

Attachment: patch

Fix the current libbz2 stream usage.  We need to loop on BZ_FINISH until BZ_STREAM_END is returned.

Comment 5

[Darin Fisher]

Comment on attachment 219111 [details] [diff] [review]
patch

r=darin

Comment 6

[Brian Ryner (not reading)]

checked in, branch and trunk.