334894 - Adding pref observer in during parse causes "no xbl binding" error

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Aaron Boodman]

Adding a preference observer via nsIPrefBranch2.addObserver causes "no xbl binding" error at: http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/browser.js#783

Was not able to understand why, or get a consistent repro. On one of our test systems, it happened at least 50% of the time.

We suspect that it was because this system had massive amounts of pref data caused by a greasemonkey script. *blink* *blink* ;)

Moving the addObserver call to the xul window's onload event solved the problem.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

What does "during parse" mean? Do you have a testcase? This is from an extension, I'm guessing?

Comment 2

[Aaron Boodman]

Sorry, by "during parse" I mean, from the top-level script inside a <script> block overlayed in browser.xul.

I don't have a testcase. Darin and Ben have been urging me to file bugs, even w/o testcases or repros. If you can't repro by filling up prefs.js and adding an observer in a browser.xul overlay, let me know and I'll try to make a repro.

Comment 3

[buovjaga]

Is this still valid? If yes, test case would be cool.

Comment 4

[:Gijs (away/busy until Mar 10)]

Going to mark wfm as we're phasing out XUL add-ons, the link is dead, fixing the link to point to dxr points to a code comment... so there isn't really enough here to fix anything.