334940 - Build failure in mozilla/browser directory

Status: RESOLVED INCOMPLETE

(Firefox Build System :: General, defect)

Description

[Laxmi Harikumar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: 

When I run 'gmake' in mozilla/browser directory, I get a core dump. This is the error message:

gmake[3]: Leaving directory `/usr/users/builds/mozilla/browser/components/build'
/usr/users/builds/mozilla/config/nsinstall -R -m 644 nsIBrowserHandler.idl nsIBr
owserGlue.idl ../../dist/idl
/usr/users/builds/mozilla/config/nsinstall -R -m 644 _xpidlgen/nsIBrowserHandler
.h _xpidlgen/nsIBrowserGlue.h ../../dist/include/browsercomps
gmake[2]: Leaving directory `/usr/users/builds/mozilla/browser/components'
/usr/bin/ksh: 273743 Memory fault(coredump)
gmake[1]: *** [export] Error 139
gmake[1]: Leaving directory `/usr/users/builds/mozilla/browser'
gmake: *** [all] Error 2

I did some analysis and found that if I modify line 162 of mozilla/toolkit/mozapps/installer/packager.mk from:

ifneq (1_,$(if $(CROSS_COMPILE),1,0)_$(UNIVERSAL_BINARY)) to

ifneq (1_,$((if $(CROSS_COMPILE),1,0)_$(UNIVERSAL_BINARY)))

the build is sucessful in mozilla/browser directory.

I do not have any idea why this is happening...


Reproducible: Always

Steps to Reproduce:
1. Go to mozilla/browser
2. Run gmake
3.

Actual Results:  
Build fails (core dumps)

Expected Results:  
Build should have been successful

Comment 1

[Ludovic Hirlimann [:Usul]]

Could you attach a patch for your discovery ?

Comment 2

[Laxmi Harikumar]

Attachment: Patch for packager.mk file

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 219849 [details] [diff] [review]
Patch for packager.mk file

I think this should be a easy review.

Comment 4

[cls]

Comment on attachment 219849 [details] [diff] [review]
Patch for packager.mk file

How does a check to avoid signing NSS libraries in OSX builds when creating installer packages/tarballs affect the running of xpidl on OSF/1?  Can you explain the connection?  Is the problem reproducible?

The ifneq should not need the extra set of ()s. $(if) is a valid makefile construct with gnu make 3.78 or higher.

Comment 5

[Frank Wein [:mcsmurf]]

Reporter: Can you answer those questions in the review comment then? What (g)make  version do you have installed?

Comment 6

[Wayne Mery (:wsmwk)]

reporter (@digital) is of course gone