335014 - Make install links html and hide with javascript

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[alanjstr]

Please change the addon.tpl so that we write out the divs, hide those that are not appropriate via script, and remove the noscript.  

Item of concern:  What if JS is off, and there are no compatible versions?  So the user would just see that there isn't a compatible version?

Comment 1

[Rob Marshall [tH]]

Attachment: first attempt

I think this covers all cases.
- Fully cross-platform extensions get one install link, and no script.
- Extensions with multiple XPIs get all the links written out.
  - The script loops through them, and hides foreign platforms.
  - If it has hidden all the links, it inserts a "not available" note.

I've also made the install box a little bit wider so that "Install Now for Windows (XXX KB)" fits without wrapping.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: Minor adjustment to original patch

I +'d your patch, but I ended up making a couple minor adjustments.  When there was only 1 OS, it would display the link no matter what OS you were on (eg. visit on linux and it would offer the link for windows).

Other than that, I think it's a lot cleaner code - thanks. :)