335112 - Solaris builds should use -z defs

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Solaris should build with -z defs to ensure that there are no undefined symbols in libraries.

I tried to do this in bug 333640 but failed:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1145739905.29449.gz
CC -I/usr/openwin/include -I/usr/openwin/include -I/usr/sfw/include -I/usr/sfw/include/freetype2 -xbuiltin=%all -features=tmplife -norunpath -mt  -DNDEBUG -DTRIMMED -xO4  -G -z muldefs -z defs -h libmozz.so -o libmozz.so  adler32.o compress.o crc32.o deflate.o gzio.o infback.o inffast.o inflate.o inftrees.o trees.o uncompr.o zutil.o    -lpthread -M /usr/lib/ld/map.noexstk -xildoff -z lazyload -z combreloc  -R/usr/openwin/lib -R/usr/sfw/lib -R/usr/openwin/lib:/usr/openwin/sfw/lib -L/usr/openwin/lib -L/usr/sfw/lib -L/usr/openwin/sfw/lib -lXft -lfreetype -lXrender -lfontconfig -R/usr/openwin/lib -R/usr/sfw/lib -R/usr/openwin/lib:/usr/openwin/sfw/lib -L/usr/openwin/lib -L/usr/sfw/lib -L/usr/openwin/sfw/lib -lXft -lfreetype -lXrender -lfontconfig -z ignore -R '$ORIGIN:$ORIGIN/..'    -lsocket -ldl -lm    
Undefined			first referenced
 symbol  			    in file
free                                gzio.o  (symbol belongs to implicit dependency /lib/libc.so.1)
fopen                               gzio.o  (symbol belongs to implicit dependency /lib/libc.so.1)
[... many more libc symbols ...]

I backed out those changes for now so that solaris can build again, but ideally it would use -z defs.

Comment 1

[Gregory Szorc [:gps]]

Mozilla removed Solaris support for the build system in bug 1255813.

Comment 2

[Mike Hommey [:glandium]]

FWIW, Solaris support was re-added in bug 1354510, but that doesn't make this bug more relevant.