nsProfileCollector::LogMemory unnecessarily truncates memory size

RESOLVED FIXED

Status

Toolkit Graveyard
Data Collection/Metrics
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
I noticed this warning:

c:/builds\mozilla\metrics\mozilla\extensions\metrics\src\nsProfileCollector.cpp(181) : warning C4244: 'initializing' : conversion from 'PRUint64' to 'PRInt32', possible loss of data

and added the easy fix (we don't ever need to truncate this to PRInt32).
(Assignee)

Comment 1

12 years ago
Created attachment 219472 [details] [diff] [review]
patch
Attachment #219472 - Flags: first-review?(marria)

Updated

12 years ago
Attachment #219472 - Flags: first-review?(marria) → first-review+
(Assignee)

Comment 2

12 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

7 years ago
Component: Data Collection/Metrics → Data Collection/Metrics
Flags: first-review+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.