Closed Bug 335119 Opened 18 years ago Closed 18 years ago

nsProfileCollector::LogMemory unnecessarily truncates memory size

Categories

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Product:
Toolkit Graveyard
Component:
Data Collection/Metrics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

patch
778 bytes, patch
Details | Diff | Splinter Review 
I noticed this warning:

c:/builds\mozilla\metrics\mozilla\extensions\metrics\src\nsProfileCollector.cpp(181) : warning C4244: 'initializing' : conversion from 'PRUint64' to 'PRInt32', possible loss of data

and added the easy fix (we don't ever need to truncate this to PRInt32).
Attached patch patch — — Splinter Review 

        Attachment #219472 -
        Flags: first-review?(marria)

    
  

        Attachment #219472 -
        Flags: first-review?(marria) → first-review+

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Flags: first-review+
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: