335212 - Building of latest trunk failed.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Oleg Romashin (:romaxa)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1

Standart building of mozilla trunk failed.

Reproducible: Always

Steps to Reproduce:
1.Get the latest mozilla sources (trunk)
cvs -z3 -d :pserver:[e-mail]:/cvsroot co
mozilla/client.mk
2. make -f client.mk checkout MOZ_CO_PROJECT=xulrunner
3. build it.

Actual Results:  
Build succeded

Expected Results:  
Building failed with messages:
..............
nsImageMap.cpp: In member function `nsresult nsImageMap::AddArea(nsIContent*)':
nsImageMap.cpp:867: error: `rect' is not a member of `nsHTMLAtoms'
nsImageMap.cpp:867: error: `rectangle' is not a member of `nsHTMLAtoms'
nsImageMap.cpp:868: error: `poly' is not a member of `nsHTMLAtoms'
nsImageMap.cpp:868: error: `polygon' is not a member of `nsHTMLAtoms'
nsImageMap.cpp:868: error: `circle' is not a member of `nsHTMLAtoms'
nsImageMap.cpp:869: error: `circ' is not a member of `nsHTMLAtoms'
...................

Additional:
sFrame.h:229: warning: `virtual nsIAtom* nsFrame::GetType() const' was hidden
nsSpacerFrame.cpp:64: warning:   by `PRUint8 SpacerFrame::GetType()'
nsSpacerFrame.cpp: In member function `PRUint8 SpacerFrame::GetType()':
nsSpacerFrame.cpp:164: error: `line' is not a member of `nsHTMLAtoms'


Patch will be applied

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: BUGFIX

Added missed elements in GkAtomList

Comment 2

[Simon Montagu :smontagu]

Fixes for this have been checked in already.

Comment 3

[Alfred Peng]

=> Confirm: Tinderbox ok

Comment 4

[Simon Paquet [:sipaq]]

Comment on attachment 219581 [details] [diff] [review]
BUGFIX

This bug has already been fixed by a bustage checkin.