If update of Thunderbird was paused, incorrect message is shown

RESOLVED FIXED in mozilla1.9.1b2

Status

()

RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: unghost, Assigned: unghost)

Tracking

Trunk
mozilla1.9.1b2
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

13 years ago
If update of Thunderbird was paused, user sees message: "You have paused downloading this update. Do you want %S to download the update in the background while you continue to browse?"
The problem that you can not browse with Thunderbird - it's mail application. Obviously this phrase was written with Firefox in mind, though this part of localization belongs to Toolkit.
Patch is following.
(Assignee)

Comment 1

13 years ago
Created attachment 219614 [details] [diff] [review]
Proposed patch

Proposed patch.
Attachment #219614 - Flags: review?
(Assignee)

Updated

13 years ago
Attachment #219614 - Flags: review? → review?(mconnor)
"while you continue to work with application" doesn't seem quite right. Maybe just "while you continue to work"?
(Assignee)

Comment 3

13 years ago
(In reply to comment #2)
> "while you continue to work with application" doesn't seem quite right. Maybe
> just "while you continue to work"?
> 
I'm not native English speaker, so you should know better. Do you want me to make new patch or I should wait for more input from mconnor/beltzner? 
(Assignee)

Comment 4

13 years ago
Created attachment 220030 [details] [diff] [review]
Proposed patch v.2

With comments from Gavin addressed.
Attachment #219614 - Attachment is obsolete: true
Attachment #220030 - Flags: review?(mconnor)
Attachment #219614 - Flags: review?(mconnor)

Comment 5

12 years ago
The latest update (yesterday) cannot be installed and consequently prevents me from accessing my thunderbird email.  very serious for me
Product: Firefox → Toolkit
Comment on attachment 220030 [details] [diff] [review]
Proposed patch v.2

this needs to change the string name, here and in the consumers, so that localizers re-translate it as well.
Attachment #220030 - Flags: review?(mconnor) → review-
Hey Boriss, could you give input on this string change? I would prefer something that didn't mention work.

-resumePausedAfterCloseMessage=You have paused downloading this update. Do you want %S to download the update in the background while you continue to browse?
+resumePausedAfterCloseMessage=You have paused downloading this update. Do you want %S to download the update in the background while you continue to work?
Alexander, please hold off on this change until a new string is provided by Boriss. At that time a new patch can be created with that string and the resumePausedAfterCloseMessage property name will need to be changed so localizers will see that the string has changed. Thanks
Created attachment 343626 [details] [diff] [review]
New patch with suggestion for paused update message

My suggestion is attached.  I agree with Rob, that implying the user is doing a particular task (like work) does not make sense with an application like Thunderbird.  The verb "browse" for a browser essentially fits any Firefox-related task, but for an application the only action we know the user is taking is using that application.  So, I changed "work" to "use."
Attachment #220030 - Attachment is obsolete: true
(Assignee)

Comment 10

10 years ago
Created attachment 343639 [details] [diff] [review]
Patch v.3

Patch with Jennifer Boriss' text. Property name is changed.
Attachment #343639 - Flags: review?(robert.bugzilla)
Attachment #343639 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 343639 [details] [diff] [review]
Patch v.3

Looks good... just use resumePausedAfterCloseMsg for the name. Thanks!
(Assignee)

Comment 12

10 years ago
Created attachment 344133 [details] [diff] [review]
Patch for checkin
[Checkin: Comment 13]
Assignee: nobody → unghost
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Attachment #343626 - Attachment is obsolete: true
Comment on attachment 344133 [details] [diff] [review]
Patch for checkin
[Checkin: Comment 13]

http://hg.mozilla.org/mozilla-central/rev/f5593ad6dcc0
Attachment #344133 - Attachment description: Patch for checkin → Patch for checkin [Checkin: Comment 13]
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite-
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.