335266 - If update of Thunderbird was paused, incorrect message is shown

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Alexander L. Slovesnik]

If update of Thunderbird was paused, user sees message: "You have paused downloading this update. Do you want %S to download the update in the background while you continue to browse?"
The problem that you can not browse with Thunderbird - it's mail application. Obviously this phrase was written with Firefox in mind, though this part of localization belongs to Toolkit.
Patch is following.

Comment 1

[Alexander L. Slovesnik]

Attachment: Proposed patch

Proposed patch.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

"while you continue to work with application" doesn't seem quite right. Maybe just "while you continue to work"?

Comment 3

[Alexander L. Slovesnik]

(In reply to comment #2)
> "while you continue to work with application" doesn't seem quite right. Maybe
> just "while you continue to work"?
> 
I'm not native English speaker, so you should know better. Do you want me to make new patch or I should wait for more input from mconnor/beltzner? 

Comment 4

[Alexander L. Slovesnik]

Attachment: Proposed patch v.2

With comments from Gavin addressed.

Comment 5

[John williams]

The latest update (yesterday) cannot be installed and consequently prevents me from accessing my thunderbird email.  very serious for me

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 220030 [details] [diff] [review]
Proposed patch v.2

this needs to change the string name, here and in the consumers, so that localizers re-translate it as well.

Comment 7

[Robert Strong (they/them - no direct email)]

Hey Boriss, could you give input on this string change? I would prefer something that didn't mention work.

-resumePausedAfterCloseMessage=You have paused downloading this update. Do you want %S to download the update in the background while you continue to browse?
+resumePausedAfterCloseMessage=You have paused downloading this update. Do you want %S to download the update in the background while you continue to work?

Comment 8

[Robert Strong (they/them - no direct email)]

Alexander, please hold off on this change until a new string is provided by Boriss. At that time a new patch can be created with that string and the resumePausedAfterCloseMessage property name will need to be changed so localizers will see that the string has changed. Thanks

Comment 9

[Jennifer Morrow [:Boriss] (UX)]

Attachment: New patch with suggestion for paused update message

My suggestion is attached.  I agree with Rob, that implying the user is doing a particular task (like work) does not make sense with an application like Thunderbird.  The verb "browse" for a browser essentially fits any Firefox-related task, but for an application the only action we know the user is taking is using that application.  So, I changed "work" to "use."

Comment 10

[Alexander L. Slovesnik]

Attachment: Patch v.3

Patch with Jennifer Boriss' text. Property name is changed.

Comment 11

[Robert Strong (they/them - no direct email)]

Comment on attachment 343639 [details] [diff] [review]
Patch v.3

Looks good... just use resumePausedAfterCloseMsg for the name. Thanks!

Comment 12

[Alexander L. Slovesnik]

Attachment: Patch for checkin [Checkin: Comment 13]

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 344133 [details] [diff] [review]
Patch for checkin
[Checkin: Comment 13]

http://hg.mozilla.org/mozilla-central/rev/f5593ad6dcc0