Closed
Bug 335397
Opened 19 years ago
Closed 19 years ago
Improve jsDriver.pl timeout handling
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
2.10 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Bug 331478 introduced timeout handling in jsDriver.pl based on the code in the tinderbox utilities, but it is way too slow. The use of a non blocking waitpid with a sleep 1 in the loop makes the full test suite take many hours.
|
Assignee | |
Comment 1•19 years ago
|
||
This appears to be working fine in windows/cygwin, mac and linux.
Attachment #219770 -
Flags: review?(mrbkap)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 219770 [details] [diff] [review]
patch v1
Looks good to me.
Attachment #219770 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checking in jsDriver.pl;
/cvsroot/mozilla/js/tests/jsDriver.pl,v <-- jsDriver.pl
new revision: 1.63; previous revision: 1.62
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•