335543 - Don't use PangoWeight values outside the permissible range (100..900)

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Darshan Santani]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.1) Gecko/20060313 Fedora/1.5.0.1-9 Firefox/1.5.0.1 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.1) Gecko/20060313 Fedora/1.5.0.1-9 Firefox/1.5.0.1 pango-text

The function "PangoWeight CalculateWeight (PRUint16 aWeight) " in nsFontMetricsPango.cpp is returning *999* as one of the return values, but as per the *PangoWeight enum* defined in Pango API (reference link below), the maximum permissible return value is *900*. 

Link for Pango API (PangoWeight enum) 
http://pango.org/manual/pango-Fonts.html#id2926866


Reproducible: Always

Comment 1

[Mike Shaver (:shaver emeritus)]

I blame blizzard. :)

(If you intend to fix this bug, please feel free to assign it to yourself!)

Comment 2

[Philip Withnall (unavailable)]

http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsPango.cpp#1584
Confirmed.

Comment 3

[Darshan Santani]

I can fix this issue.  Please assign this bug to me. 

Comment 4

[Mats Palmgren (inactive)]

gfx/src/gtk/nsFontMetricsPango.cpp have been removed on trunk, but the code
in the function ThebesStyleToPangoWeight() in gfx/thebes/src/gfxPangoFonts.cpp
seems to be identical so I'm guessing this is still a problem on trunk.
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/gfx/thebes/src/gfxPangoFonts.cpp&rev=1.84&root=/cvsroot&mark=358#311

Comment 5

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Like so?

Comment 6

[Mats Palmgren (inactive)]

Checked in to trunk at 2007-06-18 20:08 PDT.

-> FIXED