335586 - Content may prevent infobar to show up when a popup is blocked

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Content may listen DOMPopupBlocked event and call event.stopPropagation(). That prevents infobar to show.
Testcase and patch coming.

(Not sure if this is actually security sensitive, 
and what should be the component?)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 219929 [details] [diff] [review]
proposed patch

asking second review from Neil, for the xpfe part.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Do you want to do this for the other undocument DOM events our chrome relies on too?  See https://bugzilla.mozilla.org/show_bug.cgi?id=286013#c0

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Ok, I'll go through all those events and their event listeners.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I'd propose to make those events to not bubbling. That would force chrome
to use right phase for event listeners.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 219929 [details] [diff] [review]
proposed patch

checked in to trunk

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 219929 [details] [diff] [review]
proposed patch

and branch too

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Make chrome to listen capture phase

Similar patch for other events.
I'd like to get this to 1.8 too, but after it has been on trunk few days.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

mconnor, any chance to get a review? ;)

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 220014 [details] [diff] [review]
Make chrome to listen capture phase

Always possible, direct poking works if I'm a bottleneck.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Checked in to trunk. Will ask for an approval for branch within next few days.