[FIX]Text control frames do XUL visibilty:collapse handling

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla1.9alpha1
x86
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [reflow-refactor], URL)

Attachments

(1 attachment)

The testcase should render identically to:

  data:text/html,a<input style="visibility: hidden">b

and doesn't.  I suspect we should be able to remove this visibility:collapse stuff, since that would be handled by the <xul:textbox> in all actual use.  But we'll see after reflow branch lands.
Whiteboard: [reflow-refactor]
Created attachment 252277 [details] [diff] [review]
Fix.
Attachment #252277 - Flags: superreview?(roc)
Attachment #252277 - Flags: review?(roc)
Assignee: nobody → bzbarsky
Summary: Text control frames do XUL visibilty:collapse handling → [FIX]Text control frames do XUL visibilty:collapse handling
Target Milestone: --- → mozilla1.9alpha
Attachment #252277 - Flags: superreview?(roc)
Attachment #252277 - Flags: superreview+
Attachment #252277 - Flags: review?(roc)
Attachment #252277 - Flags: review+
Fixed.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
The first testcase for this bug is failing for me on Windows (with native theme turned off due to bug 369040) an on Linux -- there's a slight difference in vertical positioning of both lines.  So it seems like this either isn't quite fixed or it's regressed in the past 11 days.
It regressed as a result of the checkin for bug 243370.  Filed bug 369127.
You need to log in before you can comment on or make changes to this bug.