335726 - Mark all INBOX Folders as favorite folders initially..

Status: RESOLVED WONTFIX

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Right now, the first time you open the favorite folder view, you get a blank folder pane because you haven't set any favorites up yet.

I think we should pre-populate the favorites view with your INBOX folders. 

A one time migration that sets the favorite flag on all inbox folders should do the trick.

We may also want to set it when we create new accounts for first time users as well.

Comment 1

[Scott MacGregor]

Attachment: half of the fix

Here's the first part of the fix. The first time we run with a build that supports folder views, mark the inboxes for all of the existing accounts as favorites in order to pre-populate the view.

Still to do:

1) For new users, we should think about marking inboxes for newly created accounts as favorite folders. 

2) Should we mark other folders as favorites? (Drafts?)

Comment 2

[David :Bienvenu]

Comment on attachment 223499 [details] [diff] [review]
half of the fix

I'm not sure this does the right thing with deferred accounts - you might want to add a check that the server isn't a pop3 deferred server.

Comment 3

[Scott MacGregor]

In the same vain, it would be nice if folders created or newsgroups subscribed were automatically added to the favorites view if the folder view is currently set to favorites.

Comment 4

[Mike Cowperthwaite]

(In reply to comment #1)
> 2) Should we mark other folders as favorites? (Drafts?)

If the automatically-created "Starred" search folder is implemented as planned, it should be a favorite when created.


(In reply to comment #3)
> In the same vain, it would be nice if folders created or newsgroups subscribed
> were automatically added to the favorites view if the folder view is currently
> set to favorites.

Instead, how about adding a "Favorite" checkbox on the Create Folder dialog?  (Also on the Create Search Folder dialog.)  The box could default to checked if viewing Favorites.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Seems like we'd really be guessing what the person wants from favorites here.  Likely a better solution would be to inline offer a way to add folders to your favorites instead of just adding all your Inboxes.  Not sure it's worth working on the favorites system at this point as bug 446306 is about implementing a new style folder pane.

-> WONTFIX

Comment 6

[Magnus Melin [:mkmelin]]

Marking wontfix then in favor of an inline solution. It is a bit empty the first time you get there.