335777 - Revert bookmarks.html back to 1.5.0.x (plus mozilla.com)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Axel Hecht [:Pike]]

Now that places isn't in 2.0 anymore, we should revert the changes to bookmarks.html.

We should sneak in the changes in our URL structure, though. Maybe as two steps.

Bookmarks shouldn't contain traces of places, IMHO, even on the trunk.

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 328711 has been marked as a duplicate of this bug. ***

Comment 2

[Charli Li (winsxs)]

Also, to add to the reasons why places should be disabled, you just can't add bookmarks in places like before, when it wasn't places.  It looked better the old way.  Even more, the Add Bookmark command (dialog) in the Bookmarks menu looks appalling.

Comment 3

[Phil Ringnalda (:philor)]

[e-mail] : although you might have been confused by Axel's technical comment about how "Bookmarks shouldn't contain traces of places," this bug, and any other bug for that matter, is an inappropriate place for that comment. The newsgroup if you have something constructive and useful to offer, forums.mozillazine.org if you want to complain until a moderator quashes you, but not Bugzilla.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: Revert to 1.5.0

Given the different review needs between "this structure won't break Places" and "these are the URIs we want to keep around," two-stepping it sounds reasonable. This patch just goes back to the 1.5.0.x bookmarks.html, which seems to work just fine trunk and branch, Places and not (as it should, since the importer has to deal with it being created in 1.5 and then imported).

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Can you also add a link to mozilla.org? I don't think we should remove a link to our community apparatus.

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Revert and fixup v.1

Okay, let's get it in one shot.

- added m.o/contribute/
- fixed the mostly-incorrect LAST_CHARSETs
- changed m.c/products/firefox/central.html to /firefox/central/ (twice)

Leftovers from bug 310625:

- http -> https for addons
- icons for Answers.com, Wikipedia, Sfx

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 220671 [details] [diff] [review]
Revert and fixup v.1

r=[e-mail]

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Retargetted at beta 1

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk.
mozilla/browser/locales/en-US/profile/bookmarks.html 	1.13

Comment 10

[u60234]

Comment on attachment 220671 [details] [diff] [review]
Revert and fixup v.1

>Index: browser/locales/en-US/profile/bookmarks.html
>===================================================================

>+        <DT><A HREF="http://www.mozilla.com/" ICON="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAHWSURBVHjaYvz//z8DJQAggJiQOe/fv2fv7Oz8rays/N+VkfG/iYnJfyD/1+rVq7ffu3dPFpsBAAHEAHIBCJ85c8bN2Nj4vwsDw/8zQLwKiO8CcRoQu0DxqlWrdsHUwzBAAIGJmTNnPgYa9j8UqhFElwPxf2MIDeIrKSn9FwSJoRkAEEAM0DD4DzMAyPi/G+QKY4hh5WAXGf8PDQ0FGwJ22d27CjADAAIIrLmjo+MXA9R2kAHvGBA2wwx6B8W7od6CeQcggKCmCEL8bgwxYCbUIGTDVkHDBia+CuotgACCueD3TDQN75D4xmAvCoK9ARMHBzAw0AECiBHkAlC0Mdy7x9ABNA3obAZXIAa6iKEcGlMVQHwWyjYuL2d4v2cPg8vZswx7gHyAAAK7AOif7SAbOqCmn4Ha3AHFsIDtgPq/vLz8P4MSkJ2W9h8ggBjevXvHDo4FQUQg/kdypqCg4H8lUIACnQ/SOBMYI8bAsAJFPcj1AAEEjwVQqLpAbXmH5BJjqI0gi9DTAAgDBBCcAVLkgmQ7yKCZxpCQxqUZhAECCJ4XgMl493ug21ZD+aDAXH0WLM4A9MZPXJkJIIAwTAR5pQMalaCABQUULttBGCCAGCnNzgABBgAMJ5THwGvJLAAAAABJRU5ErkJggg==" ID="rdf:#$+vPhC3" LAST_CHARSET="UTF-8" ID="rdf:#$+vPhC3">Mozilla.com</A>

Duplicate ID attributes here.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/profile/bookmarks.html 	1.4.8.12

Comment 12

[:Gavin Sharp [email: [e-mail]]]

I checked in the double attribute fix on the trunk.

Comment 13

[Phil Ringnalda (:philor)]

*** Bug 318200 has been marked as a duplicate of this bug. ***