335793 - Auto 100% on a task causes item to be crossed off

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[marcus.monaghan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051104 Mozilla Sunbird/0.3a1

When I add a new task I tab through the fields filling them in as I go. When I come to the status I use the down arrow to select the appropriate status. However, I found that it auto fills the "% complete on" when I select a status of "completed on", but then leaves it at 100% when I select another Status.

Reproducible: Always

Steps to Reproduce:
1. Add a new task
2. Select Completed On
3. Select Needs Action
4. Save the task. The task is marked as complete and crossed off.

Actual Results:  
The task is marked as complete and crossed off.

Expected Results:  
Perhaps it should warn me that I have marked the task as 100% but the task is not complete or cancelled.

This is a very minor thing and now I know about it I make a conscious decision not to do it.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I don't actually think this is so minor, because it could cause the user to lose track of a task that isn't finished.  Marcus, do you still see this with nightly builds?

Comment 2

[marcus.monaghan]

Dan,

I have just downloaded and tried the nightly build, but it is still defaulting to 100%. So, yes I am seeing it on nightly builds.

Regards,
Marcus

Comment 3

[Martin Schröder [:mschroeder]]

Can confirm this on latest Sunbird nightly build.

Comment 4

[Joey Minta]

Unfortunately, I don't see a clean solution to this problem.  The two possibilities I can think of are:
1.) Change the percent complete when the user reverts a task from compeleted.
Problem: What values makes sense here? 90%?
2.) Flash a warning.
Problem: All other warnings in the dialog block the 'OK' function, and actually correspond to invalid data.

Thinking about it more though, maybe 100%, without status Completed is invalid data and should block the dialog?

I'm also thinking about beltzner's comment about the over-emphasis a lot of calendar programs place on %-complete, but we run into inter-op problems, when users can't access the data set by other programs.  Thoughts?

Comment 5

[marcus.monaghan]

Thoughts:

When you scroll through the status why not set the percentage complete to 100% if the status is complete, but revert to the percentage if another selection is made. 

For example. If I scroll through the status field and select "Complete" the percentage complete would go to 100%. If I then select another status it reverts to the previous value.

Example Data:
Status=Not Specified,% Complete=0
Status=Needs Action,% Complete=0
Status=In Process,% Complete=0
Status=Completed on,% Complete=100
Status=Cancelled,% Complete=0
Status=Not Specified,% Complete=0
Status=Needs Action,% Complete=0
... etc.

Example Data2:
Status=Not Specified,% Complete=0
Status=Needs Action,% Complete=25
Status=In Process,% Complete=25
Status=Completed on,% Complete=100
Status=Cancelled,% Complete=25
Status=Not Specified,% Complete=25
Status=Needs Action,% Complete=25
... etc.

Hope this make sense.

Comment 6

[Matthew (lilmatt) Willis]

(In reply to comment #4)
> Thinking about it more though, maybe 100%, without status Completed is invalid
> data and should block the dialog?

No. Bad. When I import a file with a slew of 100%s and no COMPLETEDs, I don't want to wade through a slew of "you've gotta fix this" modal dialogs.


> I'm also thinking about beltzner's comment about the over-emphasis a lot of
> calendar programs place on %-complete, but we run into inter-op problems, when
> users can't access the data set by other programs.  Thoughts?

Perhaps a better solution is to break the default associations between 100%, COMPLETE, and strikethrough? 

Perhaps only break those associations on import? (Prob a bad idea.)

Comment 7

[Joey Minta]

(In reply to comment #5)
> When you scroll through the status why not set the percentage complete to 100%
> if the status is complete, but revert to the percentage if another selection is
> made. 
> 
This doesn't solve the case of changing from COMPLETED to another status when editing a completed event.  There's no alternative value to revert to.

Comment 8

[Joey Minta]

Attachment: set blank

Talked this over with dan and we agreed to just go ahead and set the task complete to blank when this happens.

Comment 9

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 225943 [details] [diff] [review]
set blank

r=shaver

Comment 10

[Joey Minta]

patch checked in.

Comment 11

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060902 Calendar/0.3a2+