335872 - <menupopup> within <toolbarbutton> ignores position

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Pam Greene]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060426 BonEcho/2.0a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060426 BonEcho/2.0a1

A <menupopup> inside a <toolbarbutton type="menu-button"> always appears after_start, aligned with the whole button's left edge, no matter what the position property of the menupopup is.

Reproducible: Always

Steps to Reproduce:
Load attached test case.

Actual Results:  
Menu appears aligned with the left edge of "Long Menu Label Text".

Expected Results:  
Menu should appear aligned with the right edge of the button/dropdown combination, due to the position="after_end" property.

Comment 1

[Pam Greene]

Attachment: Test case demonstrating error

Comment 2

[Pam Greene]

From Comment #2 of bug 336868, concerning a <menupopup position="after_end"> within a <toolbarbutton type="menu-button">:

Mac trunk and 1.8 branch: popup always appears to the right, although it's
specified to open to the left.  Linux 1.8 branch: popup always appears to the
left.  (Linux trunk not tested.) Windows trunk and branch: popup appears to the left the first time each session, then to the right thereafter. 

All nightly builds from 2006-05-08.

Comment 3

[Mike Connor [:mconnor]]

Neil, this is bug I was talking about..

Comment 4

[Neil Deakin]

Attachment: Convert position attribute in this other place the attributes are parsed

This patch can be for the branch if desired.

Comment 5

[Pam Greene]

Thanks, applying this to the branch is definitely desired.

Comment 6

[Pam Greene]

I see this has all its reviews.  Is it waiting for anything more before it's landed?

Comment 7

[Neil Deakin]

It's already been checked in on the trunk.

Comment 8

[Pam Greene]

Excellent.  Is there any reason not to check it into the 1.8 branch now too?

Comment 9

[Pam Greene]

Landed on branch; not marking as fixed even though it appears to have landed on trunk too, since Neil may have had some other reason for leaving that.

fixed-1.8-branch, fixed-on-trunk