335916 - Locale packs <em:type>8</em:type> don't register chrome

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Axel Hecht [:Pike]]

I have a test locale pack that tries to localize the stockwatcher2 example.
The chrome isn't registered on trunk.
If I comment out the <em:type>8</em:type> line in my install.rdf, the 
localization works fine, otherwise it doesn't.

Test case:
http://people.mozilla.com/~axel/stockwatcher2.xpi is the stockwatcher extension,
with hacked install.rdf to work on trunk
http://people.mozilla.com/~axel/stockwatcher2-de.xpi is the broken locale pack.

On the mac, I don't get around to start up the extension manager, it spews out
debug js stacks for xpnativewrapper being on wrong threads or something like
that. Not sure if that's connected.

Comment 1

[u60234]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.9a1) Gecko/20060428 Minefield/3.0a1

This regressed between 2006-02-06-06 and 2006-02-07-05:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-06+05%3A00%3A00&maxdate=2006-02-07+06%3A00%3A00&cvsroot=%2Fcvsroot
Possibly bug 310843. See also bug 326274, comment#6.

Comment 2

[Robert Strong (they/them - no direct email)]

Bah... when bug 286034 added EM locale types it didn't wire up the rest of the EM code or ui for that matter to support locale types

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: screenshot after upcoming patch

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch (add locales and plugins to ExtensionDirs in extensions.ini and treat the same as extensions)

This just treats locales and plugins the same as extensions as they were before the patch from bug 310843 landed to fix another bug. We might want to consider having separate sections in extensions.ini for locales and plugins but that would be another bug.

Comment 5

[Benjamin Smedberg]

Comment on attachment 220332 [details] [diff] [review]
patch (add locales and plugins to ExtensionDirs in extensions.ini and treat the same as extensions)

I don't think there's any need for a separate extensions.ini section: themes are mainly separate because they have special security requirements (only register skin packages, don't load components/plugins/etc), while locale packs and plugins are fully-privileged so it doesn't really matter.

Comment 6

[Robert Strong (they/them - no direct email)]

Landed on trunk

Comment 7

[Robert Strong (they/them - no direct email)]

Verbal a+ from bsmedberg... checked in to MOZILLA_1_8_BRANCH