All users were logged out of Bugzilla on October 13th, 2018

Coverity 456, resource leak

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
3 years ago

People

(Reporter: jonsmirl, Unassigned)

Tracking

({coverity, memory-leak})

Trunk
x86
Linux
coverity, memory-leak

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
Fix error condition memory leak in char* nsRegisterItem::toString()
(Reporter)

Comment 1

13 years ago
Created attachment 220303 [details] [diff] [review]
Reorder things to remove leak
(Reporter)

Updated

13 years ago
Attachment #220303 - Flags: review?(benjamin)

Comment 2

13 years ago
Comment on attachment 220303 [details] [diff] [review]
Reorder things to remove leak

style nit, could you make the second check (!buffer) instead of (buffer == nsnull), it's more idiomatic.
Attachment #220303 - Flags: review?(benjamin) → review-
(Reporter)

Comment 3

13 years ago
Created attachment 222177 [details] [diff] [review]
Change check to !buffer
Attachment #220303 - Attachment is obsolete: true
Attachment #222177 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #222177 - Flags: review?(benjamin) → review+

Comment 4

13 years ago
Fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

11 years ago
Keywords: mlk
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.