Closed
Bug 336008
Opened 19 years ago
Closed 19 years ago
Coverity 470, missing error check
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Core Graveyard
Installer: XPInstall Engine
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: jonsmirl, Assigned: jonsmirl)
Details
(Keywords: coverity)
Attachments
(2 files)
|
4.87 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
5.75 KB,
patch
|
Details | Diff | Splinter Review |
Rearrange things so that error code is return instead of ignored.
Attachment #220306 -
Flags: review?(benjamin)
|
||
Comment 2•19 years ago
|
||
Can I get this patch with a lot more context?
Most of the diff is caused by an indentation change from removing an if level. Here is a -b version, but commit the first version so the white space will be right.
|
|
||
Updated•19 years ago
|
Attachment #220306 -
Flags: review?(benjamin) → review+
|
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
||
Updated•19 years ago
|
Assignee: xpi-engine → jonsmirl
|
|
||
Comment 4•19 years ago
|
||
Checked in on the trunk.
mozilla/xpinstall/src/nsXPInstallManager.cpp 1.144
Status: NEW → RESOLVED
Closed: 19 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
Attachment #222878 -
Attachment is patch: true
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•