336037 - Provide interface for reviewers to alter add-on data during review

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Reviewers should be able to edit description, versions, categories, the new metadata that's coming online like costs-money,prerelease,site-specific, etc.

In many cases, this would result in less effort for the reviewers than deny-with-comment, new-upload, rinse-and-repeat.

Comment 1

[Cameron]

Would need to be something like: 
reviewer adjusts -> reviewer approves -> developer approves
so that developers don't get their extensions screwed over by someone making a mistake and adjusting something incorrectly.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I don't know if it would "have" to be like that.  Reviewers who do the wrong things with extensions can hurt things, and will always be able to (even if we were to outsource our reviews to C|Net! :) ), so I'm not presently inclined to add more workflow there.

Comment 3

[Wil Clouser [:clouserw]]

Editor's can now "Edit Item" from the "Review add-on" page.

Comment 4

[Justin Scott [:fligtar]]

Actually, that link (and the target page) only appears for admins.

If we indeed want editors to be able to edit any add-on's data, that would be fairly easy to do with the new permissions. I already created a group called "Senior Editors" that can do that, but if we want normal editors to be able to do that, that's fine.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I think it's OK to restrict to a Senior Editors group, yeah.  Good call.