Closed Bug 336099 Opened 18 years ago Closed 14 years ago

Remove unused addons.tooltip from browser.dtd

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.7a5

People

(Reporter: tbertels+bugzilla, Assigned: tdowner)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Patch v1
1010 bytes, patch
Gavin
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2

There are addons.tooltip and downloads.tooltip entitys in browser.dtd, but they aren't used anywhere.
So we should use or remove them.

Reproducible: Always
Attached patch Show the tooltips (obsolete) — — Splinter Review 

        Attachment #220387 -
        Flags: review?

    
  

        Attachment #220387 -
        Flags: review? → review?(mconnor)

    
  

        Attachment #220387 -
        Attachment is obsolete: true

        Attachment #220387 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 220387 [details] [diff] [review]
Show the tooltips

Menu items don't show tooltips.

downloads.tooltip is used for the optional Downloads toolbar button.

addons.tooltip is not used anywhere, so that should be removed:
http://mxr.mozilla.org/mozilla-central/search?string=addons.tooltip

    
    

    
  
Morphing bug (was: Tooltip not shown for Addons and Downloads menu items).
URL: http://mxr.mozilla.org/mozilla-centra...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Tooltip not shown for Addons and Downloads menu items → Remove unused addons.tooltip from browser.dtd
Version: unspecified → Trunk

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1
        — 
          — Splinter Review
      

    


  
Think this should do it, only one reference to it in mxr.
Assignee: nobody → tyler.downer
Status: NEW → ASSIGNED

        Attachment #438681 -
        Flags: review?(steffen.wilberg)

    
    

    
  
Comment on attachment 438681 [details] [diff] [review]
Patch v1

Looks good, but I'm not a reviewer. Pick one from here:
http://www.mozilla.org/projects/firefox/review.html

        Attachment #438681 -
        Flags: review?(steffen.wilberg)

    
    

    
  
Comment on attachment 438681 [details] [diff] [review]
Patch v1

sorry steffen :)

        Attachment #438681 -
        Flags: review?(gavin.sharp)

        Attachment #438681 -
        Flags: review?(gavin.sharp) → review+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/bebf253e16c5
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5

    
    

    
  
V.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: