336119 - Lost out-of-memory error in source/xslt/txXSLTPatterns.cpp:56

Status: RESOLVED INCOMPLETE

(Core :: XSLT, defect)

Description

[Denis Vlasenko]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060320 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060320 Firefox/1.5

nsresult txPattern::getSimplePatterns(txList& aList)
{
    aList.add(this);
    return NS_OK;
}

But add() may fail! See below:

nsresult txList::add(void* objPtr)
{
    return insertBefore(objPtr, 0);
}

nsresult txList::insertBefore(void* objPtr, ListItem* refItem)
{
    ListItem* item = new ListItem;
    NS_ENSURE_TRUE(item, NS_ERROR_OUT_OF_MEMORY);
...

add() fails if "new ListItem" fails, but getSimplePatterns() never reports that.

Reproducible: Always

Comment 1

[Denis Vlasenko]

source/xslt/txStylesheet.cpp:436

    txList simpleMatches;
    rv = aTemplate->mMatch->getSimplePatterns(simpleMatches);
    if (simpleMatches.get(0) == aTemplate->mMatch) {
        aTemplate->mMatch.forget();
    }

rv is never checked for error conditions.

Comment 2

[Peter Van der Beken [:peterv]]

And the problem is... ?

Comment 3

[Wayne Mery (:wsmwk)]

do you still see problem if you use current beta, latest version of all plugins (for example flash v10 - check using about:plugins), java (1.6_0_13), etc
started in safe mode
 https://support.mozilla.com/en-US/kb/Safe+Mode
- latest beta
 http://www.mozilla.com/en-US/firefox/all-beta.html

Comment 4

[Tyler Downer [He/Him]]

No reply, INCO. Please reopen if you still see this bug in Firefox 3.5 or later in Firefox safe mode (http://support.mozilla.com/en-US/kb/Safe+Mode) or a new Firefox profile (http://support.mozilla.com/en-US/kb/Profiles) with updated plugins.