336128 - Missing out-of-memory checks in security/nss/lib/freebl/mpi/utils/*

Status: RESOLVED WONTFIX

(NSS :: Libraries, defect)

Description

[Denis Vlasenko]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060320 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060320 Firefox/1.5

security/nss/lib/freebl/mpi/utils/fact.c:76
    buf = malloc(len);
    mp_todecimal(&a, buf);

    puts(buf);

security/nss/lib/freebl/mpi/utils/dec2hex.c:62
  buf = malloc(len);
  mp_toradix(&a, buf, 16);

  printf("%s\n", buf);

security/nss/lib/freebl/mpi/utils/prng.c:73
  seed = malloc(bbs_seed_size);
  for(ix = 0; ix < bbs_seed_size; ix++) {
    seed[ix] = rand() % UCHAR_MAX;
  }

security/nss/lib/freebl/mpi/utils/hex2dec.c:62
  buf = malloc(len);
  mp_toradix(&a, buf, 10);

  printf("%s\n", buf);

security/nss/cmd/crmf-cgi/crmfcgi.c:224
  var = malloc(sizeof(CGIVariable));
  var->name = form_output;
  var->value = &equal[1];
  varTable->variables[varTable->numVars] = var;
  varTable->numVars++;
...
  varTable->variables = malloc(sizeof(CGIVariable*)*DEFAULT_CGI_VARS);
  varTable->numVars = 0;
  varTable->numAlloc = DEFAULT_CGI_VARS;

security/nss/cmd/swfort/instinit/instinit.c:242
    file.data = malloc(size);
    file.len = size;

    file.len = PR_Read(fd,file.data,file.len);

security/nss/cmd/bltest/blapitest.c:2624
        param = malloc(100);
        len = fread(param, 1, 100, file);

security/nss/cmd/pwdecrypt/pwdecrypt.c:320
           result.data = malloc(inText->len+1);
           result.len = inText->len+1;
           rv = PK11SDR_Decrypt(inText, &result, NULL);


Reproducible: Always

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Getting the hint yet ?

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

All these bug reports about OOM errors in the NSS QA test program sources
are not terribly useful.  Expect them to be marked WONTFIX or made very low
priority.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Tiny little unit test programs like this don't run out of memory.