336134 - Missing out-of-memory check at db/sqlite3/src/shell.c:1485

Status: RESOLVED FIXED

(Toolkit :: Storage, defect, P1)

Description

[Denis Vlasenko]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060320 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060320 Firefox/1.5

        nSql = strlen(zLine);
        zSql = malloc( nSql+1 );
        strcpy(zSql, zLine);


Reproducible: Always

Comment 1

[Nickolay_Ponomarev]

I don't think we actually use that but submitted an sqlite ticket anyway:
http://www.sqlite.org/cvstrac/tktview?tn=1805

Denis: please file bugs in correct components (check bonsai and/or ask for help on irc.mozilla.org if you don't know where a bug belongs). Also please but a bonsai link highlighting the problematic code to the URL field of the bug (e.g. for this bug the link would be http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/db/sqlite3/src/shell.c&rev=1.6&mark=1468-1470#1464 ). Last, are these found by coverity (if so, please add the "coverity" keyword).

Comment 2

[timeless]

coverity access is currently restricted. i actively chose not to file bugs against sqlite when i reviewed the coverity results. it does indeed find a number of them, but it seemed like a bad use of my time.

Comment 3

[Brett Wilson]

This is fixed by the upgrade to sqlite 3.3.5 in bug 338155.

Comment 4

[Brett Wilson]

Fixed by patch in bug 338155.