33615 - Clicking on a news URL promptly crashes

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Simon Fraser [no longer active]]

I click on a news URL (have no news accounts set up), and promptly crash:

 Calling chain using A6/R1 links
  Back chain  ISA  Caller
  00000000    PPC  1F3C3F34  
  08ECE940    PPC  1F3AE7BC  main+00240
  08ECE8A0    PPC  1F3ACEC8  main1(int, char**, nsISplashScreen*)+00810
  08ECE7A0    PPC  1F31D2BC  nsAppShellService::Run()+1D2BC
  08ECE750    PPC  1D1931F4  nsAppShell::Run()+00040
  08ECE710    PPC  1D193A08  nsMacMessagePump::DoMessagePump()+00044
  08ECE6C0    PPC  1D193E0C  nsMacMessagePump::DispatchEvent(int, EventRecord*)+
001B0
  08ECE670    PPC  1F434A24  Repeater::DoRepeaters(const EventRecord&)+0003C
  08ECE620    PPC  1D16EB80  nsMacNSPREventQueueHandler::RepeatAction(const 
EventRecord&)+000
14
  08ECE5E0    PPC  1D16EE5C  nsMacNSPREventQueueHandler::ProcessPLEventQueue()+
00274
  08ECE550    PPC  1D740600  nsEventQueueImpl::ProcessPendingEvents()+00068
  08ECE4E0    PPC  1D7B6F94  PL_ProcessPendingEvents+00084
  08ECE490    PPC  1D7B70D8  PL_HandleEvent+00054
  08ECE450    PPC  1D059484  HandlePLEvent(OnLinkClickEvent*)+00014
  08ECE410    PPC  1D05951C  OnLinkClickEvent::HandleEvent()+0004C
  08ECE3D0    PPC  1D059CEC  nsWebShell::HandleLinkClickEvent(nsIContent*, 
nsLinkVerb, const 
unsigned short*, const unsigned short*, nsIInputStream*)+0013C
  08ECE1E0    PPC  1D056AAC  nsWebShell::LoadURL(const unsigned short*, const 
char*, nsIInput
Stream*, int, unsigned int, unsigned int, nsISupports*, const unsigned short*, 
const char*)+0
0EC8
  08ECDA90    PPC  1D0545C4  nsWebShell::LoadURI(nsIURI*, const char*, 
nsIInputStream*, int, 
unsigned int, unsigned int, nsISupports*, const unsigned short*, const char*)+
00090
  08ECDA30    PPC  1D04FFE0  nsWebShell::DoLoadURL(nsIURI*, const char*, 
nsIInputStream*, uns
igned int, unsigned int, const unsigned short*, const char*, int)+00E38
  08ECD6E0    PPC  1D05236C  nsGetServiceByProgID::nsGetServiceByProgID(const 
char*, nsISuppo
rts*, unsigned int*)+00EF8
  08ECD6A0    PPC  1D149524  nsMsgProtocol::Release()+49524
  08ECD660    PPC  1D0F7400  nsNNTPProtocol::~nsNNTPProtocol()+F7400
  08ECD610    PPC  1D0E6F30  nsNNTPHost::Release()+E6F30
  08ECD5D0    PPC  1D0E7228  nsNNTPHost::~nsNNTPHost()+E7228
  08ECD590    PPC  1D0E7528  nsNNTPHost::CleanUp()+E7528
  08ECD550    PPC  1D879D40  PR_Free+00014
  08ECD510    PPC  1D8E06C4  free+00024
 Closing log

It looks like m_optionLines has never been initialized, because I guess
nsNNTPHost::Initialize() was never called. Why isn't the ctor of nsNNTPHost 
clearing those member variables, tsk tsk!

Comment 1

[lchiang]

We have a bug on ths.  I'll find it.

http://bugzilla.mozilla.org/show_bug.cgi?id=22889 - I think.

I'll let mscott triage this.

Comment 2

[(not reading, please use [e-mail] instead)]

this is me.  i'll do the fix and the bug wrangling.

thanks for the good bug report, simon.

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.  a lot of uninitialized variables, yikes.

Comment 4

[laurel]

OK, no crash, using:
2000-03-30-10 m15 commercial build mac OS 9.0
2000-03-30-09 m15 commercial build NT 4.0
2000-03-30-09 m15 commercial build linux rh6.0

There are some oddities if clicking on news url if you do have news accounts,
but they're fairly minor. And, since we have autosubscribe kind of work on the
plate for the near future, there's no sense logging them.  Ref feature bug
#11075.