336176 - Builds with places disabled still have places-specific code

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Nickolay_Ponomarev]

Builds with places disabled still have some places-specific code.

Some things I noticed:
http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/browser.xul#47 (<?xml-stylesheet href="chrome://browser/content/places/places.css" causes a warning message in a debug build; that file is also referred to from other XUL files)

Places-specific CSS rules:
http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/browser.css
http://lxr.mozilla.org/mozilla1.8/source/browser/themes/winstripe/browser/browser.css

Comment 1

[Jo Hermans]

(In reply to comment #0)
> http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/browser.xul#47
> (<?xml-stylesheet href="chrome://browser/content/places/places.css" causes a
> warning message in a debug build; that file is also referred to from other XUL
> files)

that was fixed in bug 335925

Comment 2

[Joey Minta]

Attachment: ifdef places style rules

Patch is based off of a cvs-blame examination of the files mentioned in comment #0.  I did a quick lxr examination of other occurrences of "places" and nothing else jumped out at me as needing to be removed.

Comment 3

[Joey Minta]

Patch landed on trunk and branch.  This *should* be everything.  Re-open if other places code is found.

Comment 4

[Phil Ringnalda (:philor)]

Although winstripe's preprocessed, browser/themes/pinstripe/browser/browser.css isn't, so your ifdef there isn't working.

Comment 5

[Adam Guthrie]

Attachment: preprocess pinstripe's browser.css

See philor's comment above.

Comment 6

[Joey Minta]

Patch landed on branch and trunk.

Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.12.2.11; previous revision: 1.12.2.10

Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.24; previous revision: 1.23

Comment 7

[Josh Aas]

the last checkin for this caused bug 342061

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv