336190 - Uninitialized variable in nsSVGUtils::ObjectSpace (layout/svg/base/src/nsSVGUtils.cpp)

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Kenneth Herron]

Please refer to the sample URL. The variable |fraction| is only initialized when the test at lines 534-535 succeeds. But it's unconditionally used to calculate the return value.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 220620 [details] [diff] [review]
patch

r=jwatt, but please break it over two lines so as not to exceed the 80 chars/line limit:

    fraction =
      aLength->GetAnimValue(NS_STATIC_CAST(nsSVGCoordCtxProvider*, nsnull));

Comment 3

[Robert Longson [:longsonr]]

Attachment: address review comment

Comment 4

[Robert Longson [:longsonr]]

Checked in

Checking in nsSVGUtils.cpp;
/cvsroot/mozilla/layout/svg/base/src/nsSVGUtils.cpp,v  <--  nsSVGUtils.cpp
new revision: 1.22; previous revision: 1.21
done