336214 - Can't move (drag and drop) multiple bookmarks from one folder to another

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Franklin Bynum]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1

When two or more bookmarks are selected in Places, and then dragged to a folder, nothing happens.  When I select only one of the bookarms and try to move it, it moves successfully.

Reproducible: Always

Steps to Reproduce:
1. Select multiple bookmarks
2. Drag to a folder
3. 

Actual Results:  
Nothing happens

Expected Results:  
All bookmarks should be moved to the folder

Comment 1

[Philip Withnall (unavailable)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1 - Build ID: 0000000000
Confirmed.

Comment 2

[Ria Klaassen (not reading all bugmail)]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060501 Minefield/3.0a1

Comment 3

[Philip Withnall (unavailable)]

Linux-only, then?

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 337466 has been marked as a duplicate of this bug. ***

Comment 5

[Christine Yen]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a6pre) Gecko/20070613 Minefield/3.0a6pre ID:0000000000

Confirmed on OS X. I'll look into this bug..

Comment 6

[(not reading, please use [e-mail] instead)]

I'm not seeing on windows (like Ria reported in comment #2), but I was also seeing it on mac.

although, I was seeing that when moving multiple bookmarks, only one would get moved.

Comment 7

[Christine Yen]

From controller.js ( http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/controller.js#1491 ), session.numDropItems is returning 1 by default on the mac, pointing to platform-specific widget code... here: http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsDragService.cpp#748

Comment 8

[Christine Yen]

(In reply to comment #7)
> From controller.js (
> http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/controller.js#1491
> ), session.numDropItems is returning 1 by default on the mac, pointing to
> platform-specific widget code... here:
> http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsDragService.cpp#748
> 

Actually - Adam pointed out that cocoa is now enabled on trunk ( http://lxr.mozilla.org/seamonkey/source/widget/src/cocoa/nsDragService.mm#525 )

Comment 9

[Christine Yen]

From playing with Venkman: both nsDragService::GetNumDropItems and nsDragService::GetData are having issues on OS X. If I manually change the value of "dropCount" to be 2 or 3 using Venkman, the loop pulls the same item 2 or 3 times. If I change both the value of "dropCount" and make sure to change the id + url of the "data" on one of the iterations of the loop, both items are transferred correctly.

So - it looks like when using the cocoa widget, session.getData isn't putting the right values into nsTransferable, and getNumDropItems isn't returning the correct number of elements to drag.

From spending a bit of time with Venkman in Linux, all I could see was that dropCount is getting populated correctly there, but something's going wrong later in the function.

Comment 10

[Christine Yen]

This bug also applies to multiple DnD in Thunderbird on Mac (e.g. dragging multiple messages from the Inbox onto the "Trash" folder in the left pane), and is almost definitely a platform bug, not a front-end one. CC'ing the appropriate people

Comment 11

[(not reading, please use [e-mail] instead)]

let's keep this bug about linux, and use bug #385116 for the mac.

for linux, christine writes:

"you simply can't drag multiple items.  on linux, dropCount is correctly returned."

Comment 12

[(not reading, please use [e-mail] instead)]

with mac, we confirmed this was a toolkit bug by debugging and also by testing tbird trunk.  (see bug #385116).

can someone with linux try tbird linux on trunk?

Comment 13

[Adam Guthrie]

version 3.0a1pre (20070622)

Dragging of multiple e-mail messages in Thunderbird trunk on Linux works fine for me, FWIW.

Comment 14

[(not reading, please use [e-mail] instead)]

adam, thanks for trying on trunk tbird linux.

based on your comments, this is sounding more like a places bug, and not a widget bug.

for now, bringing back to places, but we could use some help in debugging this on linux.

Comment 15

[Michael Wu [:mwu]]

Attachment: Check all flavors, v1

Not sure why the first flavor should always be the correct flavor when looking in a list.. so this removes that assumption. In the case of dragging bookmarks, we need the third flavor, not the first. The cocoa DnD code iterates through all the possible flavors, so I suppose this shouldn't be too wrong.

However, I'm curious as to why the TB DnD code works and the places code doesn't.

Comment 16

[Michael Wu [:mwu]]

Checking in widget/src/gtk2/nsDragService.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsDragService.cpp,v  <--  nsDragService.cpp
new revision: 1.18; previous revision: 1.17
done