336215 - Implement getBrowserAtIndex in SeaMonkey tabbrowser

Status: RESOLVED DUPLICATE of bug 482291

(SeaMonkey :: Tabbed Browser, defect)

Description

[Antonio Agreiter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.13) Gecko/20060414
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.13) Gecko/20060414

Before the Mozilla start I receive in a window this message
 Clrtb: Inizialisation failed to attach; TypeError: gBrowser.getBrowserAtIndex is not a function
 I click ok and Mozilla finally start

Reproducible: Always




Theme: blue orbit
Cookie Manager : use default permissions
Image Manager : use default permissions

Comment 1

[Andrew Schultz]

The string "Clrtb" does not exist in our code.  Do you have an extension installed that might be?  getBrowserAtIndex is a Firefox-only tabbed browser method.

Comment 2

[freekamel]

The problem is generated by the extension Colorful ..
It's not for SeaMonkey by for FireFox only.

I resolve the question myself and the 
i wrote to the creator for fixing the problem..


Bye Bye

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Do we want to implement a getBrowserAtIndex?

Comment 4

[[e-mail]]

(In reply to comment #3)
>Do we want to implement a getBrowserAtIndex?
We should; currently we're expensively recalculating this.browsers[i] in loops.

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: add it, use it in a couple of places

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

There are a couple loops that use this.browsers.length as a loop bound.  Maybe those should change too.

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Pretend that .diff only had the first part.

Comment 8

[[e-mail]]

If jag wants us to cache .browsers we don't need getBrowserAtIndex any more.

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #8)
> If jag wants us to cache .browsers we don't need getBrowserAtIndex any more.
> 

Unless we want extensions that depend on it to work.

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Updating summary to reflect the real RFE here.

I discussed this with Neil, and this is a WONTFIX.  Extension authors should use the .browsers array.

If it turns out that a huge number of extensions do depend on this, then I guess we may have to revisit it in the future, but so far we haven't seen other complaints.

Comment 11

[Philip Chee]

This is a WFM See Bug 482291 for implementation.