336270 - rounding of buttons at bottom of scrollbar does not match gtk theme (clearlooks)

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Jonathan Haas]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060502 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060502 Minefield/3.0a1

Rounded scrollbars do not match the gtk theme.
See screenshot.

Reproducible: Always

Steps to Reproduce:
1. Install attached clearlooks theme
2. Start firefox
3. Load a big webpage
4. Take a look at the scrollbars

Actual Results:  
Scrollbar look wrong

Expected Results:  
Scrollbar should look like in other gtk applications

This is related to Bug 263444 and Bug 300207.

Comment 1

[Jonathan Haas]

Attachment: Screenshot

Left in the screenshot is the scrollbar of a gnome-terminal, right is Firefox/Minefield. Notice the difference at the bottom.

Comment 2

[Jonathan Haas]

Attachment: GTK Theme file for testing (gtkrc)

You probably need the clearlooks-engine to use this.

Comment 3

[Philip Withnall (unavailable)]

Dupe of bug #206554?

Comment 4

[Jonathan Haas]

I don't think so.

Bug 206554 is probably a dupe of Bug 263444. 
This Bug is about incorrectly rounded scrollbarbuttons, Bug 206554 is about missing scrollbarbuttons.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I see this too (on FC5, with Clearlooks and a trunk Firefox non-cairo build), and it seems like a recent regression.  Did something about bug 263444 break the patch to bug 300207?

Comment 6

[Jonathan Haas]

This is not only at the bottom of a scrollbar. The same problem happens in a horizontal scrollbar on the right.

Comment 7

[Jonathan Haas]

(In reply to comment #5)
> I see this too (on FC5, with Clearlooks and a trunk Firefox non-cairo build),
> and it seems like a recent regression.  Did something about bug 263444 break
> the patch to bug 300207?

If I remember correctly, this bug also appereared after Bug 300207 was fixed and before bug 263444 was fixed.

Perhaps the patch in Bug 300207 was incorrect?

Comment 8

[Adam Guthrie]

So here's the deal: for the default gtkrc that GNOME ships with, the patch in bug 300207 works great, but for "blingly" Clearlooks themes (that use a spiffed up gtkrc) like the one that FC5 and Ubuntu Dapper Drake ship with, we don't seem to get the rounded style on down or right arrows.

The patch for bug 300207 seemed to do something about this here: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/gtk2/gtk2drawing.c&rev=1.20&mark=684-687#671
but maybe that just wasn't enough. I looked into this (looking at the Clearlooks code) and didn't get too far. 

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There's an additional patch in bug 300207, for what it's worth, and I just came up with a rather similar patch.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

For what it's worth, here's the patch I came up with before finding the one on bug 300207.  My gut feeling is that we probably want *rect rather than button_rect, but I'm not sure, and in my theme there's no difference between the two.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.