ValidateVersions() does a numeric comparison between file revision numbers, but files belonging to branches are of the form 22.214.171.124. This is filling my apache error log: Argument "126.96.36.199" isn't numeric in numeric ne (!=) at /var/www/html/doctor/doctor.cgi line 316
Created attachment 220581 [details] [diff] [review] patch, v1 Another advantage of doing a string comparison is that 1.2 == 1.20, but 1.2 ne 1.20!! So even with numbers, doing a numeric comparison can generate a wrong check.
Attachment #220581 - Flags: review?(myk)
Attachment #220581 - Flags: review?(myk) → review+
Checking in doctor.cgi; /cvsroot/mozilla/webtools/doctor/doctor.cgi,v <-- doctor.cgi new revision: 1.24; previous revision: 1.23 done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.