ValidateVersions() assumes file revision numbers to be of the form x.y

RESOLVED FIXED

Status

Webtools Graveyard
Doctor
--
minor
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
ValidateVersions() does a numeric comparison between file revision numbers, but files belonging to branches are of the form 1.12.4.2. This is filling my apache error log:

Argument "1.1.1.1" isn't numeric in numeric ne (!=) at /var/www/html/doctor/doctor.cgi line 316
(Assignee)

Comment 1

12 years ago
Created attachment 220581 [details] [diff] [review]
patch, v1

Another advantage of doing a string comparison is that 1.2 == 1.20, but 1.2 ne 1.20!! So even with numbers, doing a numeric comparison can generate a wrong check.
Attachment #220581 - Flags: review?(myk)
Attachment #220581 - Flags: review?(myk) → review+
(Assignee)

Comment 2

12 years ago
Checking in doctor.cgi;
/cvsroot/mozilla/webtools/doctor/doctor.cgi,v  <--  doctor.cgi
new revision: 1.24; previous revision: 1.23
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.