336366 - Add search engine fallback leads to 404 Mycroft page

Status: RESOLVED INVALID

(www.mozilla.org :: General, defect)

Description

[Cameron]

http://www.mozilla.com/firefox/updated.html and http://www.mozilla.com/firefox/central/index.html 

Javascript appears to be have been copied from mycroft. Should just show an error alert instead of going to http://mycroft.mozdev.org/error.html

Related:  Bug 330272 for addons.mozilla.org. The patches will be the same general idea.

Steps to reproduce: Go to http://www.mozilla.com/firefox/central/index.html in Opera, Safari, IE, etc.

Comment 1

[Cameron]

I am NOT letting anyone else at this bug after spending far too long fiddling already! :)

Comment 2

[Cameron]

Attachment: search-plugin.js

This is search-plugin.js from webtools/addons/public/htdocs/js/search-plugin.js

I don't know if there's a way you can make a "patch" to add a file.. but this is the file I want to add and I want to put it in /src/

Comment 3

[Cameron]

Attachment: Makes pages point at one file, search-plugin.js (in root directory)

Changes:

-<script type="text/javascript">
-function errorMsg(name,ext,cat)
-{
-  // alert("Netscape 6 or Mozilla is needed to install a sherlock plugin");
-  f=document.createElement("form");
-  f.setAttribute("name","installform");
-  f.setAttribute("method","post");
-  f.setAttribute("action","http://mycroft.mozdev.org/error.html");
-  fe=document.createElement("input");
-  fe.setAttribute("type","hidden");
-  fe.setAttribute("name","name");
-  fe.setAttribute("value",name);
-  f.appendChild(fe);
-  fe=document.createElement("input");
-  fe.setAttribute("type","hidden");
-  fe.setAttribute("name","ext");
-  fe.setAttribute("value",ext);
-  f.appendChild(fe);
-  fe=document.createElement("input");
-  fe.setAttribute("type","hidden");
-  fe.setAttribute("name","cat");
-  fe.setAttribute("value",cat);
-  f.appendChild(fe);
-  document.getElementsByTagName("body")[0].appendChild(f);
-  if (document.installform) { 
-    document.installform.submit();
-  } else {
-    location.href="http://mycroft.mozdev.org/error.html"; //hack for DOM-incompatible browsers
-  }
-
-}
-function addEngine(name,ext,cat,type)
-{
- if ((typeof window.sidebar == "object") && (typeof
-window.sidebar.addSearchEngine == "function")) { 
-     window.sidebar.addSearchEngine(
-       "http://addons.mozilla.org/search-engines-static/"+name+".src",
-       "http://addons.mozilla.org/search-engines-static/"+name+"."+ext, name, cat );
- } else {
-   errorMsg(name,ext,cat);
- } 
-}
-
-</script>
+<script type="text/javascript" src="/search-plugin.js></script>

Same for both files. It's uglified up because the current files have windows line endings which they shouldn't (according to Reed.)

Comment 4

[Cameron]

Ah crap. Bitrotted. And now I don't know if I screwed the patch up or if I didn't or what was wrong. Anyway mozilla.com no longer has js to add search engines on it, so this is no longer a problem.