Currently autocomplete.css includes a class "padded" specifically for an autocomplete widget to use if it doesn't have an image. However, the padding in the padded class does not match a normal textbox - it is still too small.
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Created attachment 231619 [details] [diff] [review] Better fix I got the padding wrong.
Attachment #231602 - Attachment is obsolete: true
Attachment #231619 - Flags: review?(gavin.sharp)
Created attachment 587410 [details] Screenshot of problem I retested on a current build using XUL Manager to show the testcase. Screenshot attached as well to show the problem.
Attachment #231619 - Flags: review?(gavin.sharp) → review?(dao)
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Component: XUL Widgets → Themes
Depends on: 462663
QA Contact: xul.widgets → themes
Resolution: --- → FIXED
Whiteboard: fixed by bug 462663
I just ran this on last night's nightly and it still has the same problem. The testcase shows this. This is on Windows 7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #231619 - Attachment is obsolete: false
Comment on attachment 231619 [details] [diff] [review] Better fix This patch is ancient and doesn't apply at all. Also, it's unclear what problem attachment 587410 [details] shows.
If you load the testcase (at least on Windows), you'll see that the top text field is not as tall as the other text fields. Exactly what the screenshot shows.
The top text field is expected to be smaller, since it doesn't use the 'padded' class. See also comment 0...
6 years ago is a long time to remember why I opened this. So then the better question is why does an autocomplete textbox require the padded class in order to be the same size as a regular textbox? Shouldn't these two textboxes be the same size? <textbox flex="1" type="autocomplete"/> <textbox flex="1"/>
See comment 0 again: 'autocomplete.css includes a class "padded" specifically for an autocomplete widget to use if it doesn't have an image.' In other words, without padded, you're supposed to add an icon.
> In other words, without padded, you're supposed to add an icon. But why? I wonder how I figured that out six years ago. It's not documented anywhere. I'll give up now.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.